search

trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.52k stars 721 forks source link

Tokens #55

Closed BifocalComb closed 6 years ago

BifocalComb commented 6 years ago

Transaction 0xf0cad610c300324b9e192ee3fd431d7acfcfb9a758a23bfa6865b51efc6dbfae Sent 3.9 OMG, an ERC20 token to my address. It hasn't shown up after 80 confirmations.

ghost commented 6 years ago

Hey @BifocalComb. I can see that you transfers tokens to this address: https://etherscan.io/token/OmiseGo?a=0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c

For tokens we currently using ethplorer.io API to get tokens information, it's returning 0 :( https://api.ethplorer.io/getAddressInfo/0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c?apiKey=freekey

I'm gonna look into this problem and see how we can improve this experience.

Just to confirm: 0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c is this the address you expecting tokens?

BifocalComb commented 6 years ago

Great! Thanks so much for the prompt response.

On Monday, October 16, 2017, Michael Scoff notifications@github.com wrote:

Hey @BifocalComb https://github.com/bifocalcomb. I can see that you transfers tokens to this address: https://etherscan.io/token/OmiseGo?a= 0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c

For tokens we currently using ethplorer.io http://ethplorer.io API to get tokens information, it's returning 0 :( https://api.ethplorer.io/getAddressInfo/0x24cc2359bc42b2c855678c7fae8e fbb3a7d3660c?apiKey=freekey

I'm gonna look into this problem and see how we can improve this experience.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337084654, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvCeZuFdbsRv7WTfXzY-J5Do6Gdepks5ss_lpgaJpZM4P7af_ .

ghost commented 6 years ago

@BifocalComb I just checked on https://ethplorer.io/address/0xd26114cd6ee289accf82350c8d8487fedb8a0c07#pageSize=100, it sounds like they have 19hours delay for refreshing tokens, this is ridiculous. This is not acceptable!

We need to find backend developers to make this easy to see your tokens! I'm gonna add this as a priority for us to work on!

Are you developer? we might need some help to make experience better.

ghost commented 6 years ago

I just realized that it's been around 18 hours since hard fork on Ethereum network, and their system wasn't updated to work properly.

I will keep you updated on this issue.

BifocalComb commented 6 years ago

Oh I wish I were. I'm learning, but I'm afraid I'd be of no use to you. What about the etherscan api?

On Monday, October 16, 2017, Michael Scoff notifications@github.com wrote:

@BifocalComb https://github.com/bifocalcomb I just checked on https://ethplorer.io/address/0xd26114cd6ee289accf82350c8d84 87fedb8a0c07#pageSize=100, it sounds like they have 19hours delay for refreshing tokens, this is ridiculous. This is not acceptable!

We need to find backend developers to make this easy to see your tokens! I'm gonna add this as a priority for us to work on!

Are you developer? we might need some help to make experience better.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337086096, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvNBsREutORu1YV7tBqf9c2Lhc2faks5ss_vOgaJpZM4P7af_ .

ghost commented 6 years ago

etherscan api does not provide public API for retrieving tokens yet 😢 but I will do more research

BifocalComb commented 6 years ago

https://etherscan.io/apis#tokens I might be misinterpreting this, but isn't the bottom one token balance by address? I think you might have to pay for more than 5 requests per second, though.

On Mon, Oct 16, 2017 at 8:58 PM, Michael Scoff notifications@github.com wrote:

@BifocalComb https://github.com/bifocalcomb I just checked on https://ethplorer.io/address/0xd26114cd6ee289accf82350c8d84 87fedb8a0c07#pageSize=100, it sounds like they have 19hours delay for refreshing tokens, this is ridiculous. This is not acceptable!

We need to find backend developers to make this easy to see your tokens! I'm gonna add this as a priority for us to work on!

Are you developer? we might need some help to make experience better.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337086096, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvNBsREutORu1YV7tBqf9c2Lhc2faks5ss_vOgaJpZM4P7af_ .

ghost commented 6 years ago

This will return your balance if you know contract address in advance that you need to check.

So let's say there is 1000 ERC20 contracts that you might have some amount on it, you would need to ask every contract how many tokens your wallet owns.

https://ethplorer.io would give all the tokens that you address owns. I messaged their support for more info.

BifocalComb commented 6 years ago

Ah, ok. Thanks for the explanation! I'm glad I downloaded an app with such a responsive dev team.

On Monday, October 16, 2017, Michael Scoff notifications@github.com wrote:

This will return your balance if you know contract address in advance that you need to check.

So let's say there is 1000 ERC20 contracts that you might have some amount on it, you would need to ask every contract how many tokens your wallet owns.

https://ethplorer.io would give all the tokens that you address owns. I messaged their support for more info.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337096024, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvCAQBGWCyc8WMn0VrstOA5WfBzFdks5stAwdgaJpZM4P7af_ .

ghost commented 6 years ago

@BifocalComb I'm going to close this issue in favor or https://github.com/TrustWallet/trust-wallet-ios/issues/56.

Building this API will allow us to have all the transactions and tokens available for the users, and also ability to send token as a bonus.

Hopefully to complete this in the next few weeks.

ghost commented 6 years ago

@BifocalComb can you check your tokens in Trust now? they should be available to preview!

ghost commented 6 years ago

@BifocalComb btw, I'm OMG hodler as well! Keep it up

BifocalComb commented 6 years ago

Cool! OMG certainly has potential. Unfortunately, I still am unable to see token balances in the app.

On Tuesday, October 17, 2017, Michael Scoff notifications@github.com wrote:

@BifocalComb https://github.com/bifocalcomb btw, I'm OMG hodler as well! Keep it up

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337334319, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvJGoiwVO4GHc4P117k9C5lWga_a-ks5stPkpgaJpZM4P7af_ .

ghost commented 6 years ago

Can you double check your account? 0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c - it will say in Accounts page.

I can see tokens now returned from their endpoint: https://api.ethplorer.io/getAddressInfo/0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c?apiKey=freekey

BifocalComb commented 6 years ago

Yea I just checked.. Ethplorer's API shows my correct balances... The app still shows "No Tokens" when I try to see my tokens, and I only see my transfer of 1.007 eth in the main account page.

On Tuesday, October 17, 2017, Michael Scoff notifications@github.com wrote:

Can you double check your account? 0x24cc2359bc42b2c855678c7fae8e fbb3a7d3660c - it will say in Accounts page.

I can see tokens now returned from their endpoint: https://api.ethplorer.io/getAddressInfo/0x24cc2359bc42b2c855678c7fae8e fbb3a7d3660c?apiKey=freekey

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337347418, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvBf816wIFAXR-8TH-KvuWzdV4aCZks5stQMXgaJpZM4P7af_ .

ghost commented 6 years ago

"balance":3.413892514e+19, even tough it was returning Int64 value in the past and I had to move . based on decimals value.

What's the worst, showing incorrect balance and not showing at all?

screen shot 2017-10-17 at 12 56 27 pm

Source: https://api.ethplorer.io/getAddressInfo/0x24cc2359bc42b2c855678c7fae8efbb3a7d3660c?apiKey=freekey

BifocalComb commented 6 years ago

Sorry, I'm not sure I understand your question.. Do you mean what's worse: showing the scientific notation value for balance or showing nothing? Personally I'd rather see the scientific notation balance, just to confirm my tokens were actually sent to the right address without having to use a block explorer, but I could understand why that might confuse people. There are 18 decimal places to the right of the ones place so I just imagine in my mind that huge number divided by 10^18, and that's my balance.

On Tuesday, October 17, 2017, Michael Scoff notifications@github.com wrote:

"balance":3.413892514e+19, even tough it was returning Int64 value in the past and I had to move . based on decimals value.

What's the worst, showing incorrect balance and not showing at all?

[image: screen shot 2017-10-17 at 12 56 27 pm] https://user-images.githubusercontent.com/32179653/31686349-be22499a-b33a-11e7-97fb-c2941c92c51d.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337352409, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvI6MvdQmUQsm1CraZwzkPG8B12XAks5stQdKgaJpZM4P7af_ .

ghost commented 6 years ago

Never mind, I have fixed it, sending build to the App Store! It will take another day or two.

Demo: simulator screen shot - iphone se - 2017-10-17 at 13 16 00

BifocalComb commented 6 years ago

Great thanks! I'll definitely be recommending this app.. Best customer service I've ever had by far. Some of my crypto-pals are devs so I'll definitely lyk if I get any of them on the app.

Thanks again, Andrew Grochan

On Tuesday, October 17, 2017, Michael Scoff notifications@github.com wrote:

Never mind, I have fixed it, sending build to the App Store! It will take another day or two.

Demo: [image: simulator screen shot - iphone se - 2017-10-17 at 13 16 00] https://user-images.githubusercontent.com/32179653/31687185-5f1e96c6-b33d-11e7-8fcc-125f513cb178.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337357322, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvAeZlFaNJtEG5nMhrdSW8knh-6W_ks5stQtugaJpZM4P7af_ .

ghost commented 6 years ago

Yo! New version is out! I hope this should work now!

2017-10-18 16 15 55

BifocalComb commented 6 years ago

Great! Just updated it. Thanks very much!

On Wednesday, October 18, 2017, Michael Scoff notifications@github.com wrote:

Yo! New version is out! I hope this should work now!

[image: 2017-10-18 16 15 55] https://user-images.githubusercontent.com/32179653/31747093-b71fd8c0-b41f-11e7-8b97-2a608e605f5f.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TrustWallet/trust-wallet-ios/issues/55#issuecomment-337754867, or mute the thread https://github.com/notifications/unsubscribe-auth/AfVXvECnK9UxjtORVNvITbf3InU23czlks5stocAgaJpZM4P7af_ .