search

trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.52k stars 721 forks source link

Support current merged EIP-712 specification #825

Closed leroldary closed 5 years ago

leroldary commented 6 years ago

ethereum/EIPs#712 is merged. When/How do you plan to update from your current implementation of eth_signTypedData to the new one specified in EIP-712?

vikmeup commented 6 years ago

@hewigovens can you take a look to see what we need to finish?

leroldary commented 6 years ago

Metamask will add a deprecation warning to the old implementation in the next release https://github.com/MetaMask/metamask-extension/pull/4905 and in the next release thereafter replace it with the current new EIP712 specification https://github.com/MetaMask/metamask-extension/pull/4803.

Would be great if you could update your implementation to remain compatible with metamask.

hewigovens commented 6 years ago

Thanks for your information, we will work on this soon

leroldary commented 6 years ago

Just noticed, trust wallet for android has an EIP-712 implementation. But it seems it's neither compatible with the new merged EIP-712 specification nor with the old one implemented in MetaMask (which will be replaced soon). Which version of the specification is currently implemented for the android version?

hewigovens commented 6 years ago

@leroldary Thanks, we have a branch if you'd like to track the progress.