trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.54k stars 719 forks source link

QR-code scanning: change field names to EIP-681 standard. #840

Open mesqueeb opened 6 years ago

mesqueeb commented 6 years ago

As per the EIP-681 standard (draft) the QR code scan fields are:

request                 = "ethereum" ":" [ "pay-" ]target_address [ "@" chain_id ] [ "/" function_name ] [ "?" parameters ]
target_address          = ethereum_address
chain_id                = 1*DIGIT
function_name           = STRING
ethereum_address        = ( "0x" 40*40HEXDIG ) / ENS_NAME
parameters              = parameter *( "&" parameter )
parameter               = key "=" value
key                     = "value" / "gas" / "gasLimit" / "gasPrice" / TYPE
value                   = number / ethereum_address / STRING
number                  = [ "-" / "+" ] *DIGIT [ "." 1*DIGIT ] [ ( "e" / "E" ) [ 1*DIGIT ] [ "+" UNIT ]

Especially when it comes to the value and ethereum_address fields, Trust wallet currently uses amount and ethereum. Are there any chances this standard will be supported as well in the future?

OlegGordiichuk commented 6 years ago

@mesqueeb thx for request I will do investigation on this issue.