trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.52k stars 721 forks source link

Add new line with wallet name on Transaction Confirmation #866

Closed ghost closed 6 years ago

ghost commented 6 years ago

Referencing #862

OlegGordiichuk commented 6 years ago

@BloodyPixy could you pls add image of the new UI?

ghost commented 6 years ago

@OlegGordiichuk img_0589

vikmeup commented 6 years ago

@BloodyPixy Ideally it should be: Wallet #3 (0x123...123)

Use your judgment

vikmeup commented 6 years ago

@vikmeup Wallet Title => Wallet

ghost commented 6 years ago

@vikmeup , I did it this way, because the sender address (current wallet) is included in 'Sender' field. I suggest merging sender and wallet name then. It will look more clear.

vikmeup commented 6 years ago

@BloodyPixy For sure! It should be just one field

ghost commented 6 years ago

@vikmeup let do it like this:

From Wallet Wallet Name (address)

vikmeup commented 6 years ago

@BloodyPixy 👍 nice!

ghost commented 6 years ago

@OlegGordiichuk keystore.mainWallet is not changed, when changing the wallet in settings. As I understand, there is only one mainWallet, at least until it is removed and substituted for another. We need different behavior, so I will use keystore.recentlyUsedWallet. At least, that what is done in other places.

ghost commented 6 years ago

Updated appearance img_0592