search

trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.52k stars 721 forks source link

Feature/update project configuration #890

Closed ShivaHuang closed 6 years ago

ShivaHuang commented 6 years ago

I found that this project use Gemfile.lock to provides a consistent environment.

However, not everyone follows this rule, even the Makefile.

For example, currently the version of cocoapods specified in Gemfile.lock is 1.5.0, but the Podfile.lock in master shows that it is generated by version 1.5.3.

So, this is it. I modified Makefile to use bundler to keep gems consistent. And update outdated gems also.

OlegGordiichuk commented 6 years ago

@ArtemGoryunov from my point of view it is fine commit to sync Gemfile.lock and Podfile.lock.

ArtemGoryunov commented 6 years ago

@OlegGordiichuk I agree.

ShivaHuang commented 6 years ago

So, do you guys think this PR helps?