search

trustwallet / trust-wallet-ios

:iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS
https://trustwallet.com
GNU General Public License v3.0
1.52k stars 718 forks source link

QR Code Scanner for DApp Browser #934

Closed nikitaeverywhere closed 5 years ago

nikitaeverywhere commented 5 years ago

Hello! Thank you for an excellent wallet.

It would be much appreciated if you add a QR code to an embedded dApp browser. Let me know what do you think, thanks!

image

vikmeup commented 5 years ago

@ZitRos use deep links: https://medium.com/@trustwallet/mobile-dapps-with-deep-linking-and-trust-wallet-6a4712b9b9a4

to forward your users to dapp browser!

nikitaeverywhere commented 5 years ago

@vikmeup, deep links are not the complete solution. DApps doesn't always mean mobile apps!

What about this:

There is a desktop website where you are prompted to do some Ethereum action (donation, payment, whatever) with "Pay with web3/Metamask". (It's very common for people to have a mobile wallet and also a laptop for surfing, isn't it?). Now, you want to donate/pay/whatever using your mobile wallet. Would you manually type website's URL to your DApp browser, being an inexperienced user? Never! 95% of people doesn't even know what's "DApp browser" on mobile (only we, developers, know that it injects web3 provider thanks to this cool Trust feature). The only thing that works is to state on a desktop website clearly "scan this QR on your mobile wallet". By having http(s):// link mobile wallet can quickly recognize which action to perform (obviously, open link in DApp browser).

Yes, I am aware of QR code EIP for Ethereum actions, but if you have a fully-featured web app + dApp you may need a quick switch from desktop to a mobile for certain actions.

Please reply :) Thanks!

vikmeup commented 5 years ago

If you want to pay donation, just transfer funds to specific address. I don't think I follow your logic, neither we ever tell to users about web3 or dapp browser and how to use it, it's a developers responsibility to guide them.

If you want to have good experience for the end user to do an action, follow service, do it now, before anyone claim it.

Hi, I've sent you 0.005 eth. To receive follow the link: https://eth2.io/#/r?pk=fcd17aed6cd76ca7e459dd53eeaba26947f016f69a21d9394ffea4710412927b&w=trust

Feel free to message me on telegram: @vikmeup.