search

trustwallet / wallet-connect-kotlin

95 stars 73 forks source link

add okexchain walletconnect support #23

Closed okexgithub closed 3 years ago

okexgithub commented 3 years ago

We are the developers of okexchain. We have developed the corresponding code that supports okexchain based on the wallect connect protocol. Our code has added support for okexchain. This includes the addition of resolution for OKT type signatures and transfer events.Usage examples are also included. Please help merge, thank you.

okexgithub commented 3 years ago

Would it be possible to make it compatible with eth sign? seems like it's using the same params

okexchain and eth are two chains, and there will be ambiguity if the eth sign is reused.okexchain's signature parameters are different from eth's. bnb is also independent of eth in this project.So I think it's important to make a distinction.

pedrouid commented 3 years ago

I think this dedicated method would make sense given that messages are encoded differently

vikmeup commented 3 years ago

I think this dedicated method would make sense given that messages are encoded differently

What's the current state of Wallet Core V2? Ideally we want to stay away from specific models and methods for each blockchain and make it as generic as possible.

Otherwise it's gonna be a big pain to manage dozens of different blockchain models.

BNB solution here is a temp workaround, I would rather build something more generic

vcoolish commented 3 years ago

Close until some generic solution will be added