search

trustwallet / wallet-connect-swift

WalletConnect Swift client SDK
MIT License
102 stars 130 forks source link

Session persistent support #15

Closed hewigovens closed 5 years ago

hewigovens commented 5 years ago

Fixes #7

leoneparise commented 5 years ago

Fixes #7

Can we add some unit tests?

hewigovens commented 5 years ago

@leoneparise sure, let me add codecov too

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@45b2353). Click here to learn what that means. The diff coverage is 4.79%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #15   +/-   ##
========================================
  Coverage          ?   22.3%           
========================================
  Files             ?      28           
  Lines             ?     713           
  Branches          ?       0           
========================================
  Hits              ?     159           
  Misses            ?     554           
  Partials          ?       0
Impacted Files Coverage Δ
WalletConnect/WCSession.swift 85.71% <ø> (ø)
WalletConnect/WCInteractor.swift 0% <0%> (ø)
WalletConnect/WCSessionManager.swift 0% <0%> (ø)
Example/WalletConnect/AppDelegate.swift 25% <0%> (ø)
Example/Tests/WCEncryptorTests.swift 100% <100%> (ø)
...xample/WalletConnect/WCSessionViewController.swift 8.33% <7.79%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45b2353...92bb744. Read the comment docs.