search

trustwallet / wallet-connect-swift

WalletConnect Swift client SDK
MIT License
102 stars 130 forks source link

WalletConnect eth_sendTransaction default values are invalid #6

Closed olaf89 closed 4 years ago

olaf89 commented 5 years ago

Expected Behavior

When the gas price is not provided the value is preset using user transaction cost configuration. When the nonce is not provided the value is preset, accounting for network/local latest nonce.

Current Behavior

The nonce and gasPrice is set to 0 so even tho defaults are provided they will never work.

Steps to Reproduce (for bugs)

Send transaction with nonce and gasPrice not preset by dapp.

Context

I expect WalletConnect integration to work the same way as web3 browser injected provider.

vikmeup commented 4 years ago

@hewigovens what's needed for this?

hewigovens commented 4 years ago

The app needs to check and fetch missing fields before sending tx

hewigovens commented 4 years ago

Trust iOS has fixed this