search

trustwallet / wallet-core

Cross-platform, cross-blockchain wallet library.
https://developer.trustwallet.com/wallet-core
Apache License 2.0
2.76k stars 1.56k forks source link

Remove Smart Chain Legacy #1128

Closed hewigovens closed 3 years ago

hewigovens commented 3 years ago

Next month

optout21 commented 3 years ago

It's OK to hide the legacy version from docs/coins.md temporarily, and keep only the new one, but the new should point to smartchain folder; this could be a source of confusion (we don't want new assets to bsc folder). OK?

- | 20000714 | Smart Chain      | BNB    | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/bsc/info/logo.png" width="32" />          | <https://www.binance.org/en/smartChain> |
+ | 20000714 | Smart Chain      | BNB    | <img src="https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/smartchain/info/logo.png" width="32" />          | <https://www.binance.org/en/smartChain> |
hewigovens commented 3 years ago

let's update the script to ignore legacy items

optout21 commented 3 years ago

I think that's overengineering. I think we can live with the out-of-sync coins.md file for the temp period, I can update to make sure rest is in sync (it is now), and correct folder is mentioned.