trustwallet / wallet-core

Cross-platform, cross-blockchain wallet library.
https://developer.trustwallet.com/wallet-core
Apache License 2.0
2.86k stars 1.6k forks source link

> Founded an exit path from functions with non-void return type that has missing return statement. Omitting the return statement in a function which is has a return type that is not void is undefined behavior. #2379

Closed DELJUJAZI closed 2 years ago

DELJUJAZI commented 2 years ago

Founded an exit path from functions with non-void return type that has missing return statement. Omitting the return statement in a function which is has a return type that is not void is undefined behavior.

Files:

  • src/Bitcoin/Transaction.cpp:154
  • src/Keystore/StoredKey.cpp:254
  • src/Polkadot/Extrinsic.cpp:53
  • src/PublicKey.cpp:107 / 127

Originally posted by @DELJUJAZI in https://github.com/trustwallet/wallet-core/issues/2351#issuecomment-1184918712

DELJUJAZI commented 2 years ago

Tks