Open Milerius opened 1 year ago
Nice wrap up , can you sort them from easy/small to hard? so we can tackle one by one
Nice wrap up , can you sort them from easy/small to hard? so we can tackle one by one
done
While you are at it, maybe also get rid of ruby / rust as the project is in C++?
Also noticed the actual requirements isn't listed here: https://developer.trustwallet.com/wallet-core/developing-the-library/building
As you need Ubuntu 20.04+, ruby > 2.6, latest rust, clang-14. Building wallet-core on Ubuntu 18.04 no longer works.
While you are at it, maybe also get rid of ruby / rust as the project is in C++?
Also noticed the actual requirements isn't listed here: https://developer.trustwallet.com/wallet-core/developing-the-library/building
As you need Ubuntu 20.04+, ruby > 2.6, latest rust, clang-14. Building wallet-core on Ubuntu 18.04 no longer works.
Rust is something that we would like to extend in the future, most likely moving C++ logic to rust.
Regarding ruby, it's used for codegen our bindings in swift wasm and kotlin, we do not plan to remove it for now, eventually the tool will be re-written in rust
Motivation
Most of the use of boost in the project is replaceable by our own implementations or the standard library.
This passing of dependencies in the project allows us to have more sovereignty, simplify security audits and facilitate compilation in wasm and facilitate the distribution/compilation of the project.
std::to_string, std::to_chars
alternative (good test task for candidate)Additional context