[TON] Support TON tx compiler

trustwallet / wallet-core

Cross-platform, cross-blockchain wallet library.

https://developer.trustwallet.com/wallet-core

Apache License 2.0

2.79k stars 1.57k forks source link

[TON] Support TON tx compiler #3995

Closed 10gic closed 1 month ago

10gic commented 1 month ago

Description

Implement the TON transaction compiler, fix https://github.com/trustwallet/wallet-core/issues/3797

How to test

Run Rust, C++, Kotlin, Swift tests

Types of changes

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[ ] I have read the guidelines for adding a new blockchain.

10gic commented 1 month ago

Hi @satoshiotomakan, I would greatly appreciate it if you could take the time to review this pull request.

satoshiotomakan commented 1 month ago

Hi @10gic, thank you for the PR! I'll review today

10gic commented 1 month ago

Good job again. Please consider making changes to avoid ambiguous API and doing same work multiple times

Thank you very much for your comments. I've adjusted the code according to your advice. Could you please review it again?

10gic commented 1 month ago

Hi @satoshiotomakan. I'm wondering if it's a good time to proceed with merging the code. Please let me know if there's anything else that needs to be done beforehand.