[BTC]: Add support for `signPSBT`

satoshiotomakan commented 1 month ago

Description

Add support for a limited Bitcoin PSBT signing/planning support. It includes: P2PK, P2PKH, P2WPKH, P2TR (key-path) UTXO signing. Please note P2SH, P2WSH, P2TR (script-path) are not supported yet.

How to test

Run Rust, C++, Swift, Kotlin tests

Types of changes

Add TWBitcoinPsbtSign FFI that takes BitcoinV2.PsbtSigningInput and returns BitcoinV2.PsbtSigningOutput
Add TWBitcoinPsbtPlan FFI that takes BitcoinV2.PsbtSigningInput and returns BitcoinV2.TransactionPlan - it can be used to get the transaction details such as fee, inputs and outputs amounts/addresses/scriptPubkeys.
Move integration tests from rust/tw_any_coin/tests to rust/tw_tests/tests

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

github-actions[bot] commented 1 month ago

Binary size comparison

➡️ aarch64-apple-ios:

- 12.09 MB
+ 12.14 MB   +53 KB

➡️ aarch64-apple-ios-sim:

- 12.09 MB
+ 12.15 MB   +53 KB

➡️ aarch64-linux-android:

- 15.50 MB
+ 15.58 MB   +79 KB

➡️ armv7-linux-androideabi:

- 13.24 MB
+ 13.30 MB   +57 KB

➡️ wasm32-unknown-emscripten:

- 10.98 MB
+ 11.04 MB   +61 KB

JaimeToca commented 1 month ago

Loos great @satoshiotomakan !!! . Quick question, is BIP0322 going to be handled separetly? Thanks !

satoshiotomakan commented 1 month ago

Hi @JaimeToca, BIP0322 will be released separately

trustwallet / wallet-core