trustwallet / wallet-core

Cross-platform, cross-blockchain wallet library.
https://developer.trustwallet.com/wallet-core
Apache License 2.0
2.86k stars 1.6k forks source link

[Bitcoin]: Refactor PSBT protocol #4038

Closed satoshiotomakan closed 1 month ago

satoshiotomakan commented 1 month ago

Description

We decided to refactor BitcoinV2.SigningInput to have either a TransactionBuilder or Psbt. This allows to pass PSBT signing input to AnySigner.sign and AnySigner.plan.

How to test

Run Rust, C++, iOS, Android, WASM tests

Types of changes

Checklist

If you're adding a new blockchain

github-actions[bot] commented 1 month ago

Binary size comparison

➡️ aarch64-apple-ios:

- 12.14 MB
+ 12.13 MB   -7 KB

➡️ aarch64-apple-ios-sim:

- 12.15 MB
+ 12.14 MB   -7 KB

➡️ aarch64-linux-android:

- 15.58 MB
+ 15.57 MB   -11 KB

➡️ armv7-linux-androideabi:

- 13.30 MB
+ 13.29 MB   -9 KB

➡️ wasm32-unknown-emscripten:

- 11.04 MB
+ 11.03 MB   -8 KB