Add support for xDai - Githubissues

igorbarinov commented 5 years ago

Chain ID: 100 https://blockscout.com/poa/dai Instruction https://github.com/TrustWallet/wallet-core/wiki/Adding-Support-for-a-New-Blockchain

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it as part of the poanetwork fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $39,838.61 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 11 months, 4 weeks from now. Please review their action plans below:

1) welsakka has applied to start work _(Funders only: approve worker | reject worker)_.

Hey! I am interested in completing your bounty. I have strong C++ skills, and would love to develop for Trust wallet.

-Waleed

Learn more on the Gitcoin Issue Details page.

2) jacobcreech has been approved to start work.

I have a strong C++ background, having been to a University that uses C++ as its main language. In working on this bounty, I plan on doing the following:

Create a WIP PR and provide bi-daily updates
Finish within 2 weeks
Add necessary test coverage to my implementation
Learn how the code generation works for Trust wallet and implement for xDai

I will review all the required setup for development and start work on approval.

Learn more on the Gitcoin Issue Details page.

davecraige commented 5 years ago

Very cool. Nice work moving this forward @igorbarinov.

/ @vikmeup

igorbarinov commented 5 years ago

@jacobcreech please contact me on telegram @igorbarinov if you have any questions

jacob-creech commented 5 years ago

@igorbarinov My first bi-daily update:

I set up my development environment and ran all tests to make sure everything is ready to work
I reviewed the contributions wiki
I reviewed how other coins implementation were done
I read through xDai documentation and implementation on other wallets(specifically Nifty)

I should have my first commit by the next update if all goes well. I will more than likely be contacting you on telegram soon with some questions regarding implementation.

vikmeup commented 5 years ago

@jacobcreech because Ethereum already implemented on Wallet Core, all you need is to specify configuration of the coin, should not take more than 15 minutes, no need to implement anything besides that.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

@jacobcreech

@igorbarinov please take a look at the submitted work:

PR by @jacobcreech

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$39,929.16 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

⚡️ A tip worth 100.00000 DAI (100.0 USD @ $1.0/DAI) has been granted to @jacobcreech, for this issue from @igorbarinov. ⚡️

Nice work @jacobcreech,! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

$39448.71 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

igorbarinov tipped 100.0000 DAI worth 100.0 USD to jacobcreech,.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$39,148.71 more funded OSS Work available on the Gitcoin Issue Explorer

igorbarinov commented 5 years ago

xdai_logo_circle @jacobcreech let's add the logo to README

hewigovens commented 5 years ago

please upload it to TrustWallet/tokens repo first, under coin folder, name it 700.png, size 256x256 and make sure to optimize it with pngcrush or other tools

jacob-creech commented 5 years ago

@igorbarinov @hewigovens Added PR TrustWallet/tokens#1237

hewigovens commented 5 years ago

done

trustwallet / wallet-core

Add support for xDai #80