trustwallet / wallet-core

Cross-platform, cross-blockchain wallet library.
https://developer.trustwallet.com/wallet-core
Apache License 2.0
2.78k stars 1.57k forks source link

[CI] Integrate lint #978

Closed hewigovens closed 3 years ago

hewigovens commented 4 years ago

clang-tidy or cppcheck

hewigovens commented 4 years ago

cmake "-DCMAKE_CXX_CPPCHECK=/usr/bin/cppcheck;--std=c++17;--enable=warning"

optout21 commented 3 years ago

Current status:

Some lint scripts exists, but they are not set up correctly, tools not installed, not integrated into the pipeline.

Scripts (in tools):

Script invocations in the pipeline:

Test and chose the more appropriate: clang-tiny or cppcheck.

Setup exception list, fix major deviations, and include check in CI pipeline.

One comparison of C++ static code analyzers: https://www.slant.co/topics/263/~best-open-source-c-static-analysis-tools

hewigovens commented 3 years ago

GitHub has https://securitylab.github.com/tools/codeql and action, maybe we can setup this one (security)