search

trustyai-explainability / trustyai-service-operator

TrustyAI's Kubernetes operator
Apache License 2.0
3 stars 20 forks source link

RHOAIENG-9987: Remove the central service monitor #281

Open ruivieira opened 2 months ago

ruivieira commented 2 months ago

See RHOAIENG-9987.

Remove the central ServiceMonitor. With UWM, only the local (on the service's namespace) ServiceMonitor is needed.

openshift-ci-robot commented 2 months ago

@ruivieira: This pull request references RHOAIENG-9987 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/trustyai-explainability/trustyai-service-operator/pull/281): >See [RHOAIENG-9987](https://issues.redhat.com/browse/RHOAIENG-9987). > >Remove the central `ServiceMonitor`. >With UWM, only the local (on the service's namespace) `ServiceMonitor` is needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=trustyai-explainability%2Ftrustyai-service-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/trustyai-explainability/trustyai-service-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e d14d828900e72521209d4dce80eb1f28005389c8 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).