search

truvorskameikin / udp-discovery-cpp

A small library to add local network discovery feature to your C++ programs with no dependencies
MIT License
60 stars 28 forks source link

Use proper cmake build options #7

Closed G10h4ck closed 5 years ago

G10h4ck commented 5 years ago

Require linker dependencies only if executables are built Fix missing library linking regression introduced in my previous PR

Sorry to not have included this in latest PR, you where much faster then I expected!

G10h4ck commented 5 years ago

For me it is acceptable to turn them OFF by default, but in my personal experience it have been very useful to have them complied by default with just cmake . ; make without wondering about options to test it actually worked ;) But this could be easily overcome updating the README too.

I am implementing broadcast discovery into RetroShare https://retroshare.cc and was looking for a cross-platform lightweight solution without reinventing the wheel (handling the cumbersome socket API defferences on all platforms) and without the bloat and unreliability of bonjour/avahi/zeroconf/mdns, during this quest I have found your project that seems exactly what I was looking for, at first I was a bit scared by last commit being reported in 2017, but then saw some more activity in the develop branch and I have been positively surprised by your responsiveness to pull requests :)

truvorskameikin commented 5 years ago

That is great that you find this library useful! Let's finish with formatting and merge this request without changing build options.

Please feel free to ask for adding reasonable features and to offer help here.

G10h4ck commented 5 years ago

Too late, I have already both fixed formatting, changed default build options, and updated documentation accordingly ;)

I am glad to contribute to this library :)

truvorskameikin commented 5 years ago

Thank you!