trvekvltgames / opensampler

Simple Open Source sampler for android
3 stars 1 forks source link

Feature request: play sample on button down #1

Open EricTetz opened 2 years ago

EricTetz commented 2 years ago

I just downloaded 15+ samplers for Android trying to find one for a simple purpose: my band needs to be able to trigger sounds as parts of certain songs. You need to be able to tap these with very low latency, so they can be played musically.

Almost every sampler I downloaded was terrible, either with horrid UIs are unacceptable latency. BandLab does the job very well, but it's a full blown DAW and has much more than we need, making the sample pad UI more cluttered than I'd like for live use.

Open Sampler is nearly perfect. Ultra simple, clean, attractive UI, and fast. It has one fatal flaw (for our purposes): it triggers the sample on button release rather than button press. That makes it much harder to perform samples in time with music, as you would with a drum machine.

Could Open Sampler be modified to trigger samples on button down? I see that it's using a cross platform library, which can complicate things like this, which would otherwise be trivial.

trvekvltgames commented 2 years ago

The reason it plays samples on release is that long press show the setup screen. Modifying this behaviour doesn't seem like big issue though, maybe as a toggle.

Thank you for this suggestion. I'm currently gathering feedback for the 1.0 version of the app and will be updating it accordingly. Although I can't promise a time frame, I'm quite sure version 1.1 should have this functionality.

EricTetz commented 2 years ago

I'm quite sure version 1.1 should have this functionality.

Awesome! Like I said, I downloaded 15+ samplers and didn't find one cleaner and easier to use than yours.

If the buttons were triggered on button down, it feels like the latency is low enough that it would be suitable for drums sounds or generally triggering sounds in time in a musical context. A good reference for that is the sampler in Band Camp. It has the fastest response of any sampler I tried. It doesn't allow the buttons to be labelled, though, so I'd prefer to use yours.

One other feature yours lacks that would be nice to have is "gate" mode. That means the sound starts playing on button down and stops on button up. This is great for a lot of sounds in a musical context (again, see Bandcamp for a demo). Unfortunately, it's directly at odds with your configuration scheme (holding the button). But if you change button configuration is reached, a game mode would become possible.

maybe as a toggle

I'd just make the change. I'd bet a week's salary that your current users aren't even aware that sounds triggers on button up. It's not something you notice or care about until you try to trigger things in a musical context. The app will just feel snappier after the change.