Enhancement: Make sample rate configurable

trvrnrth / esphome-bsec-bme680

ESPHome component for the Bosch BME680 sensor via BSEC providing temperature, humidity, pressure and indoor air quality measurements.

85 stars 17 forks source link

Enhancement: Make sample rate configurable #14

Closed wifwucite closed 3 years ago

wifwucite commented 3 years ago

In BME680BSECComponent::setup the sample rate is fixed to BSEC_SAMPLE_RATE_LP. It would be nice to have an optional configuration which could change it to BSEC_SAMPLE_RATE_ULP to save power.

gretel commented 3 years ago

maybe this is worth mentioning https://community.bosch-sensortec.com/t5/MEMS-sensors-forum/BME680-BSEC-Samping-Rate/td-p/11413

trvrnrth commented 3 years ago

@gretel Yep; I've started adding support for the ULP mode but don't intend to add support for custom intervals on the basis of that guidance.

gretel commented 3 years ago

@trvrnrth thanks. i wasn't intending to say it's required or even useful :)

wifwucite commented 3 years ago

Thanks for the quick enhancement.

trvrnrth commented 3 years ago

@wifwucite No problem; this one was fairly straighforward. Hope it works out for you :)

gretel commented 3 years ago

@trvrnrth works for me. thank you!

trvrnrth commented 3 years ago

@gretel Liking your choice of IAQ icon!