Vertical screen overflow

trvswgnr / bs5-lightbox

A pure JS lightbox gallery plugin for Bootstrap 5 based on the Modal and Carousel components

https://trvswgnr.github.io/bs5-lightbox/

MIT License

129 stars 28 forks source link

Vertical screen overflow #2

Closed sander-spruit closed 2 years ago

sander-spruit commented 2 years ago

Although the gallery works great, vertical images overflow the screen size and create a scroll, rather than being scaled back to fit the screen.

Edit: temporary fix;

.carousel-item img {
    width: auto !important;
    max-height: 90vh;
    margin: 0 auto;
}

trvswgnr commented 2 years ago

Thank you for bringing this to my attention. I'll take a look and patch in the next release. Are you using the default options?

Erulezz commented 2 years ago

Same issue here:

All default settings, very big images (4000x3000) and I have scrollbars in all directions. Yes, it's a big image, but the best solution is to just fit the parent instead of the scrollbars 👍🏻

@sander-spruit That doesn't fix it for me :(

trvswgnr commented 2 years ago

I see the issue but I'm not sure what I want the default behavior to be. Will implement a fix soon.

shriharshmishra commented 2 years ago

It would be great to have this feature.

trvswgnr commented 2 years ago

I believe this has been fixed in v1.7.11. Let me know if you’re still having this issue.