search

trvswgnr / bs5-lightbox

A pure JS lightbox gallery plugin for Bootstrap 5 based on the Modal and Carousel components
https://trvswgnr.github.io/bs5-lightbox/
MIT License
125 stars 28 forks source link

Gallery popup sliding in instead of just changing the image #21

Closed theDaveB closed 1 year ago

theDaveB commented 2 years ago

On the latest version of Bootstrap 5.2.0, when scrolling through a gallery of images, each image slides the whole carousel in from the whatever side you click.

If I change to the version on your demo page (5.0.2) then it works exactly like your demo.

Am new to all this so hope am doing it right by reporting it here.

trvswgnr commented 2 years ago

@theDaveB the library currently supports up to Bootstrap 5.1.3, but I am already looking at the changes made in Bootstrap 5.2. I hope to have fixes soon, but I won’t add them to official release until 5.2 is out of beta.

TenkawaBC commented 2 years ago

Download the .js file, search for "let n = "lightbox-carousel carousel";

Edit this to say: "let n = "lightbox-carousel carousel slide";

That fixes the problem. This is the part of the code that any transition effects should go. eg: carousel-fade (I just fixed it up for a site I was working on). It is also compliant with the bootstrap 5 documentation. (https://getbootstrap.com/docs/5.1/components/carousel/, look at the cross-fade section)

trvswgnr commented 1 year ago

fixed with PR #24