search

trvswgnr / bs5-lightbox

A pure JS lightbox gallery plugin for Bootstrap 5 based on the Modal and Carousel components
https://trvswgnr.github.io/bs5-lightbox/
MIT License
125 stars 28 forks source link

fix "carousel and modal settings not respected" #51

Closed jonaseberle closed 1 year ago

jonaseberle commented 1 year ago

I've tried to adjust the carousel interval but it remained the default from bootstrap.Carousel.Default.

setOptionsFromSettings() is using this.settings, but that has not yet been merged with options at that point.

Related to https://github.com/trvswgnr/bs5-lightbox/issues/46

jonaseberle commented 1 year ago

Thank you!

May I ask for a release? We went live in a project with that fix yesterday and it would be great if I could change the package that to a released version :)

trvswgnr commented 1 year ago

@jonaseberle I updated the version and build yesterday, so the change is now live in version 1.8.3

jonaseberle commented 1 year ago

I was confused because it has not shown up here https://github.com/trvswgnr/bs5-lightbox/tags yet. Maybe you forgot to push the tag?

On https://www.npmjs.com/package/bs5-lightbox it is fine. Thank you!