During a toolset update we noticed the constructor on VisualBasicCommandLineParser was public. This in turn made many of the protected members of CommandLineParser a part of the API surface as it gave external customers an inheritance path.
It was never the intent for these members to be a part of the supported API surface. Creation of the parsers is meant to be done via the Default singleton properties. There seems to be little risk that we broke any customers here and hence we decided to remove this API.
Changed Simplifier methods to throw ArgumentNullExceptions
Changed Simplifier.ReduceAsync, Simplifier.ExpandAsync, and Simplifier.Expand methods to throw ArgumentNullExceptions if any non-optional, nullable arguments are passed in. Previously the user would get a NullReferenceException for synchronous methods and an AggregateException containing a NullReferenceException for asynchronous methods.
Treat a method marked with both public and private flags as private
The scenario is loading an assembly where some methods, fields or nested types have accessibility flags set to 7 (all three bits set), which mean public AND private.
After the fix, such flags are loaded to mean private.
The compat change is we’re trading a compile-time success and runtime failure (native compiler) against a compile-time error (restoring the behavior of v1.2).
Details below:
The native compiler successfully compiles the method and field case (those only yield runtime error System.TypeLoadException: Invalid Field Access Flags) and reported an accessibility error on the nested type.
The 1.2 compiler generated errors:
error BC30390: 'C.Private Overloads Sub M()' is not accessible in this context because it is 'Private'.
error BC30389: 'C.F' is not accessible in this context because it is 'Private'.
error BC30389: 'C.C2' is not accessible in this context because it is 'Protected Friend'.
error BC30390: 'C2.Private Overloads Sub M2()' is not accessible in this context because it is 'Private'.
The 1.3 compiler crashes.
After fix, the same errors as 1.2 are generated again.
Don't emit bad DateTimeConstant, and load bad BadTimeConstant as default value instead
The change affects compatibility in two ways:
When loading an invalid DateTimeConstant(-1), the compiler will use default(DateTime) instead, whereas the native compiler would produce code that fails to execute.
DateTimeConstant(-1) will still count when we check that you don’t specify two default values. The compiler will produce an error, instead of succeeding (and producing IL with two attributes).
During a toolset update we noticed the constructor on VisualBasicCommandLineParser was public. This in turn made many of the protected members of CommandLineParser a part of the API surface as it gave external customers an inheritance path.
It was never the intent for these members to be a part of the supported API surface. Creation of the parsers is meant to be done via the Default singleton properties. There seems to be little risk that we broke any customers here and hence we decided to remove this API.
Changed Simplifier methods to throw ArgumentNullExceptions
Changed Simplifier.ReduceAsync, Simplifier.ExpandAsync, and Simplifier.Expand methods to throw ArgumentNullExceptions if any non-optional, nullable arguments are passed in. Previously the user would get a NullReferenceException for synchronous methods and an AggregateException containing a NullReferenceException for asynchronous methods.
Treat a method marked with both public and private flags as private
The scenario is loading an assembly where some methods, fields or nested types have accessibility flags set to 7 (all three bits set), which mean public AND private.
After the fix, such flags are loaded to mean private.
The compat change is we’re trading a compile-time success and runtime failure (native compiler) against a compile-time error (restoring the behavior of v1.2).
Details below:
The native compiler successfully compiles the method and field case (those only yield runtime error System.TypeLoadException: Invalid Field Access Flags) and reported an accessibility error on the nested type.
The 1.2 compiler generated errors:
error BC30390: 'C.Private Overloads Sub M()' is not accessible in this context because it is 'Private'.
error BC30389: 'C.F' is not accessible in this context because it is 'Private'.
error BC30389: 'C.C2' is not a...
_Description has been truncated_
Bumps the all group with 9 updates:
1.6.11
1.6.14
1.6.11
1.6.14
2.1.0
2.1.1
17.8.0
17.9.0
3.1.1
3.3.1
3.2.0
3.3.1
4.8.0
4.9.2
4.3.1
4.9.2
23.1.0
23.7.1
Updates
Microsoft.OpenApi.Readers
from 1.6.11 to 1.6.14Release notes
Sourced from Microsoft.OpenApi.Readers's releases.
... (truncated)
Commits
ec6a1d4
Merge pull request #1585 from microsoft/vnexta2185ea
Merge pull request #1583 from microsoft/mk/release-libraries8f8cd5e
Release libsf749231
Merge pull request #1582 from microsoft/mk/fix-stream-leave-opend763e53
Update the Read and ReadFragment method to be consistent with the change2f64478
Merge pull request #1581 from microsoft/mk/fix-stream-leave-open9036a21
Remove unnecessary param name9de2aec
Add test to validate9a47cb2
Pass the leave open setting to the StreamReader constructor to prevent the st...522f703
Merge pull request #1578 from microsoft/vnextUpdates
Microsoft.OpenApi
from 1.6.11 to 1.6.14Release notes
Sourced from Microsoft.OpenApi's releases.
... (truncated)
Commits
ec6a1d4
Merge pull request #1585 from microsoft/vnexta2185ea
Merge pull request #1583 from microsoft/mk/release-libraries8f8cd5e
Release libsf749231
Merge pull request #1582 from microsoft/mk/fix-stream-leave-opend763e53
Update the Read and ReadFragment method to be consistent with the change2f64478
Merge pull request #1581 from microsoft/mk/fix-stream-leave-open9036a21
Remove unnecessary param name9de2aec
Add test to validate9a47cb2
Pass the leave open setting to the StreamReader constructor to prevent the st...522f703
Merge pull request #1578 from microsoft/vnextUpdates
SharpYaml
from 2.1.0 to 2.1.1Release notes
Sourced from SharpYaml's releases.
Commits
c8c2cf4
Upgrade tests to net8.00aaf634
Merge pull request #118 from bdovaz/fix-IgnoreUnmatchedProperties-maps5d0236c
Update global.json to 7.x61b804e
Update test project to .NET 7ce62da7
Upgrade sdk to 7.x because dotnet-releaser is not compatible with 6.xcb0fdce
Fix IgnoreUnmatchedProperties for map typesUpdates
Microsoft.OpenApi
from 1.6.11 to 1.6.14Release notes
Sourced from Microsoft.OpenApi's releases.
... (truncated)
Commits
ec6a1d4
Merge pull request #1585 from microsoft/vnexta2185ea
Merge pull request #1583 from microsoft/mk/release-libraries8f8cd5e
Release libsf749231
Merge pull request #1582 from microsoft/mk/fix-stream-leave-opend763e53
Update the Read and ReadFragment method to be consistent with the change2f64478
Merge pull request #1581 from microsoft/mk/fix-stream-leave-open9036a21
Remove unnecessary param name9de2aec
Add test to validate9a47cb2
Pass the leave open setting to the StreamReader constructor to prevent the st...522f703
Merge pull request #1578 from microsoft/vnextUpdates
SharpYaml
from 2.1.0 to 2.1.1Release notes
Sourced from SharpYaml's releases.
Commits
c8c2cf4
Upgrade tests to net8.00aaf634
Merge pull request #118 from bdovaz/fix-IgnoreUnmatchedProperties-maps5d0236c
Update global.json to 7.x61b804e
Update test project to .NET 7ce62da7
Upgrade sdk to 7.x because dotnet-releaser is not compatible with 6.xcb0fdce
Fix IgnoreUnmatchedProperties for map typesUpdates
Microsoft.NET.Test.Sdk
from 17.8.0 to 17.9.0Release notes
Sourced from Microsoft.NET.Test.Sdk's releases.
Commits
a77b8d5
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...60eca4b
Disable testhost prestart (#4833) (#4836)053d711
Replaced obsolete NuGetAuthenticate@0 with NuGetAuthenticate@1 (#4800)f33b3e4
Fixed version in tests (#4790)f8d273c
Changed pre-release label version (#4786)2cda152
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...0b98146
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...e017f62
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...4572ac3
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov...9ba4078
[main] Update dependencies from dotnet/arcade (#4767)Updates
MSTest.TestAdapter
from 3.1.1 to 3.3.1Release notes
Sourced from MSTest.TestAdapter's releases.
Changelog
Sourced from MSTest.TestAdapter's changelog.
... (truncated)
Commits
bc4c885
Fix MSTest.SDK deps (#2650)c3973e8
Use different extension Uid for MSTest.Sdk (#2648)cc19ee3
[rel/3.3] Update dependencies from microsoft/testanywhere (#2647)15355a2
Backport arcade and pipeline changes from maina005e25
[rel/3.3] Update dependencies from microsoft/testanywhere (#2644)8c0a8fd
[rel/3.3] Fix MSTEST0005 to report only inside test classes (#2642)7590bbd
[rel/3.3] Update dependencies from devdiv/DevDiv/vs-code-coverage (#2633)a4f58aa
Fix MSTest version under testing platform (#2630)3beee7a
Fix parent package path (#2602)7219e68
fix: localization pipeline should run only on main (#2618)Updates
MSTest.TestFramework
from 3.2.0 to 3.3.1Release notes
Sourced from MSTest.TestFramework's releases.
Changelog
Sourced from MSTest.TestFramework's changelog.
... (truncated)
Commits
bc4c885
Fix MSTest.SDK deps (#2650)c3973e8
Use different extension Uid for MSTest.Sdk (#2648)cc19ee3
[rel/3.3] Update dependencies from microsoft/testanywhere (#2647)15355a2
Backport arcade and pipeline changes from maina005e25
[rel/3.3] Update dependencies from microsoft/testanywhere (#2644)8c0a8fd
[rel/3.3] Fix MSTEST0005 to report only inside test classes (#2642)7590bbd
[rel/3.3] Update dependencies from devdiv/DevDiv/vs-code-coverage (#2633)a4f58aa
Fix MSTest version under testing platform (#2630)3beee7a
Fix parent package path (#2602)7219e68
fix: localization pipeline should run only on main (#2618)Updates
Microsoft.CodeAnalysis.CSharp.Workspaces
from 4.8.0 to 4.9.2Release notes
Sourced from Microsoft.CodeAnalysis.CSharp.Workspaces's releases.
Changelog
Sourced from Microsoft.CodeAnalysis.CSharp.Workspaces's changelog.
... (truncated)
Commits
Updates
Microsoft.CodeAnalysis.CSharp
from 4.3.1 to 4.9.2Release notes
Sourced from Microsoft.CodeAnalysis.CSharp's releases.
Changelog
Sourced from Microsoft.CodeAnalysis.CSharp's changelog.