search

tryAGI / LangChain

C# implementation of LangChain. We try to be as close to the original as possible in terms of abstractions, but are open to new entities.
https://tryagi.gitbook.io/langchain/
MIT License
466 stars 71 forks source link

feat(GoogleGemini): added api usage with costs #316

Closed gunpal5 closed 2 months ago

gunpal5 commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

This update primarily focuses on enhancing the Google Generative AI integration by upgrading the package version and refining various functionalities. Key changes include modifying the GoogleChatModel constructor to accept additional parameters, simplifying JSON serialization in GoogleGeminiExtensions, and updating predefined Gemini models to use new constructor parameters. Additionally, test cases have been improved to include assertions for token usage and pricing.

Changes

File Path Change Summary
src/Directory.Packages.props Updated Google_GenerativeAI package version from 0.1.20 to 1.0.0.
src/Providers/Google/src/Extensions/... Simplified JsonSerializer.Serialize call in GetString extension method.
src/Providers/Google/src/GoogleChatModel.cs Enhanced constructor with additional parameters for context length and token prices; added methods for usage and price calculation.
src/Providers/Google/src/Predefined/... Updated parameters for GoogleChatModel constructors in various Gemini models.
src/Providers/Google/test/Tests.cs Imported GeminiProModel and added assertions for InputTokens, OutputTokens, and PriceInUsd.

🌟 In fields of code where changes bloom,
A rabbit hops, dispelling gloom.
With updates fresh, the models grow,
New versions set to steal the show.
Tokens counted, prices told,
In every line, the future bold.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sweep-ai[bot] commented 2 months ago

Sweep: PR Review

Authors of pull request: @gunpal5

src/Directory.Packages.props

Updated the version of the "Google_GenerativeAI" package from "0.1.20" to "1.0.0".

Sweep Found These Issues

  • Updating the "Google_GenerativeAI" package to version "1.0.0" may introduce breaking changes or incompatibilities with existing code that relies on version "0.1.20".
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FDirectory.Packages.props#L22 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-4d59c677ea4c9112e0ce2f2e527693f48dcbcf66ba4eeb4b01abb5f3da8bbe11R22)
src/Providers/Google/src/Extensions/GoogleGeminiExtensions.cs

Removed the custom serialization context for the arguments dictionary in the GetString method, defaulting to the standard JsonSerializer settings.

Sweep Found These Issues

  • The removal of the custom serialization context in the GetString method may lead to inconsistent serialization behavior, particularly with property naming policies, null value handling, and enum handling.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FExtensions%2FGoogleGeminiExtensions.cs#L27-L31 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-b824a38cf648640e677119465ab5182ba9adf8735fc5f709b8746ec64fd3486cR27-R31)
src/Providers/Google/src/GoogleChatModel.cs

Added configurable parameters to the GoogleChatModel constructor, introduced methods for calculating usage and price, and ensured consistent recording of usage metrics.

Sweep Found These Issues

  • The CalculatePriceInUsd method does not handle cases where inputTokenPriceUsd or outputTokenPriceUsd are zero, which could lead to incorrect pricing calculations.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FGoogleChatModel.cs#L230-L242 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-ac22968d6df5e1dfaedd507a5cf1e8c70f4e02f432a33a8e21b99e30981d32f9R230-R242)
  • Sweep has identified a redundant function: The new function is redundant because its functionality is already covered by the existing GetUsage methods in OpenAiChatModel and AnthropicModel.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FGoogleChatModel.cs#L213-L227 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-ac22968d6df5e1dfaedd507a5cf1e8c70f4e02f432a33a8e21b99e30981d32f9R213-R227)
  • Sweep has identified a redundant function: The new function is redundant because its purpose and functionality are already covered by the existing CalculatePriceInUsd methods in OpenAiChatModel and AnthropicModel.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FGoogleChatModel.cs#L230-L242 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-ac22968d6df5e1dfaedd507a5cf1e8c70f4e02f432a33a8e21b99e30981d32f9R230-R242)
Potential Issues

Sweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.

  • The CalculatePriceInUsd method does not handle cases where inputTokenPriceUsd, outputTokenPriceUsd, secondaryInputTokenPrice, or secondaryOutputTokenPrice are zero or negative, which could lead to incorrect price calculations.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FGoogleChatModel.cs#L230-L243 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-ac22968d6df5e1dfaedd507a5cf1e8c70f4e02f432a33a8e21b99e30981d32f9R230-R243)
src/Providers/Google/src/Predefined/GeminiModels.cs

Added new parameters to existing model constructors and introduced two new model classes with specific configurations.

Sweep Found These Issues

  • The Gemini15ProModel class incorrectly uses GoogleAIModels.Gemini15Flash instead of GoogleAIModels.Gemini15Pro.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FPredefined%2FGeminiModels.cs#L24-L27 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-0a95849ce69dd03e932b36249d99e7d84954552772037ce88ee8c692c3572c40R24-R27)
  • Sweep has identified a redundant function: The new function Gemini15FlashModel is redundant as it performs similar tasks to existing functions like GeminiProModel and GeminiProVisionModel but with different parameters.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Fsrc%2FPredefined%2FGeminiModels.cs#L17-L21 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-0a95849ce69dd03e932b36249d99e7d84954552772037ce88ee8c692c3572c40R17-R21)
src/Providers/Google/test/Tests.cs

Replaced GoogleChatModel with GeminiProModel in the GetWeather test and added assertions for input tokens, output tokens, and price in USD.

Potential Issues

Sweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.

  • Commenting out the second parameter GoogleAIModels.GeminiPro in the instantiation of GeminiProModel might affect its behavior if the constructor relies on that parameter.
    • https://github.com/tryAGI/LangChain/blob/40f8aa91d2d0d90745bf3b3fd363a0eff216c890/src%2FProviders%2FGoogle%2Ftest%2FTests.cs#L17 [View Diff](https://github.com/tryAGI/LangChain/pull/316/files#diff-e770801f46d7e0284ed23fc9ab0c370b102e3be3893266c6389fd96e5997bab0R17)
HavenDV commented 2 months ago

image I think need to replace Flash to Pro inside