search

tryabby / abby

Open-Source Feature Flags, Remote Config & A/B Tests for Developers ⛳🧪
https://www.tryabby.com
GNU Affero General Public License v3.0
134 stars 18 forks source link

fix: scrolling in devtools #121

Closed mwhnrt closed 6 months ago

mwhnrt commented 6 months ago

This PR relates to #119 and makes the devtools scrollable if the height exceeds the available screen height. It also styles the scrollbar for browsers supporting this, so that the scrollbar is less prominent but still visible.

It also fixes an issue of the DevTools story where required data (remoteConfig) was missing so Storybook could not render the DevTools component.

image

Summary by CodeRabbit

vercel[bot] commented 6 months ago

@mwhnrt is attempting to deploy a commit to the cstrnt's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abby-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 3:35pm
coderabbitai[bot] commented 6 months ago

Walkthrough

The recent updates focus on enhancing the user interface and functionality of the Devtools module. A new remoteConfig object has been integrated into the abbyMock object to enrich configuration options. Additionally, the layout and styling within the Devtools component have been reorganized and refined, including improved scrollbar aesthetics and a more logical placement of UI elements.

Changes

File Path Change Summary
.../devtools/src/Devtools.stories.ts Added remoteConfig object with properties config-1, config-2, config-3 to abbyMock.
.../devtools/src/Devtools.svelte Moved <hr />, reorganized content div structure, adjusted #abby-devtools styling, added scrollbar styling.

🐰✨ A hop and a skip in the code so neat, A rabbit danced with tiny feet. New configs here, a line there, Devtools shine with utmost care. Celebrate, for the changes are sweet! 🎉

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 9a45b4473f069baa72fee978b4b752ad38fa5783 and e49032702d359e97c0d1e3525ee183638bed6fa7.
Files selected for processing (2) * packages/devtools/src/Devtools.stories.ts (1 hunks) * packages/devtools/src/Devtools.svelte (4 hunks)
Additional comments not posted (3)
packages/devtools/src/Devtools.stories.ts (1)
`18-18`: Consider refining the type declaration for `config-3`. If it's intended to represent a JSON object, you might want to use a more explicit type or provide a more detailed structure.
packages/devtools/src/Devtools.svelte (2)
`96-152`: The structural adjustments within the `div` with class `content` enhance the organization and readability of the Devtools UI. Good job on improving the logical separation of sections. --- `245-265`: The custom scrollbar styling is well-implemented, aligning with modern design aesthetics while ensuring usability. The use of `rgba` for color transparency is a nice touch.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cstrnt commented 6 months ago

Thank you so much @mwhnrt for your contribution! :octocat:

simonorzel26 commented 6 months ago

Thank you very much sir. @mwhnrt :shipit: 🙏