Closed rajesh-jonnalagadda closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
abby-docs | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Jun 18, 2024 10:01am |
abby-opensource | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Jun 18, 2024 10:01am |
@rajeshj11 is attempting to deploy a commit to the cstrnt's projects Team on Vercel.
A member of the Team first needs to authorize it.
[!IMPORTANT]
Review skipped
Review was skipped due to path filters
Files ignored due to path filters (1)
* `pnpm-lock.yaml` is excluded by `!**/pnpm-lock.yaml`You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The update focuses on replacing the rate limiting and Redis dependencies from Upstash with rate-limiter-flexible
to make the application more self-hostable. @upstash/ratelimit
and @upstash/redis
dependencies were removed from the project, and the core rate limiting logic was refactored to use RateLimiterRedis
from rate-limiter-flexible
.
File | Change Summary |
---|---|
apps/web/package.json | Removed @upstash/ratelimit and @upstash/redis . Added rate-limiter-flexible . |
.../src/api/routes/v1_event.ts | Replaced Upstash ratelimit logic with rateLimiter implementation using rate-limiter-flexible . |
.../src/server/common/ratelimit.ts | Introduced new rateLimiter setup and checkRateLimit function using RateLimiterRedis . |
Objective (Issue #) | Addressed | Explanation |
---|---|---|
Remove @upstash/redis dependency (#143) |
โ | |
Remove @upstash/ratelimit dependency (#143) |
โ | |
Add a new rate limiting library (#143) | โ |
In the codebase, nimble lines have danced, From Upstash ties, they cleanly chanced, A flexible guard, now in place, With rate limits, setting the pace. Hopping free, like a rabbit in dawn's first light, CodeRabbit smiles at this vibrant new sight.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@cstrnt please review
This looks really good! I think it would be amazing if you could extract the
checkRateLimit
function with the ratelimiter to it's own file/module so that we can potentially re-use this :) Otherwise this looks amazing!
can I move these functions to /home/rajesh/github/abby/apps/web/src/api/routes/utils.ts
This looks really good! I think it would be amazing if you could extract the
checkRateLimit
function with the ratelimiter to it's own file/module so that we can potentially re-use this :) Otherwise this looks amazing!can I move these functions to /home/rajesh/github/abby/apps/web/src/api/routes/utils.ts
Would prefer server/common/ratelimit.ts
This looks really good! I think it would be amazing if you could extract the
checkRateLimit
function with the ratelimiter to it's own file/module so that we can potentially re-use this :) Otherwise this looks amazing!can I move these functions to /home/rajesh/github/abby/apps/web/src/api/routes/utils.ts
Would prefer
server/common/ratelimit.ts
done
@rajeshj11 the pnpm-lock.yaml
is out of sync. Could you please run pnpm i
locally and check in this file?
Ok
/claim #143 /fixes #143
Summary by CodeRabbit
New Features
RateLimiterRedis
.Chores
@upstash/ratelimit
and@upstash/redis
withrate-limiter-flexible
.