tryabby / abby

Open-Source Feature Flags, Remote Config & A/B Tests for Developers โ›ณ๐Ÿงช
https://www.tryabby.com
GNU Affero General Public License v3.0
143 stars 19 forks source link

fix:removed the upstash redis and upstash ratelimit #144

Closed rajesh-jonnalagadda closed 5 months ago

rajesh-jonnalagadda commented 5 months ago

/claim #143 /fixes #143

  1. removed the @upstash/redis and @upstash/rate-limit
  2. added a new package for handling the rate limit(rate-limiter-flexible)

Summary by CodeRabbit

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
abby-docs โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 18, 2024 10:01am
abby-opensource โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 18, 2024 10:01am
vercel[bot] commented 5 months ago

@rajeshj11 is attempting to deploy a commit to the cstrnt's projects Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 5 months ago

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1) * `pnpm-lock.yaml` is excluded by `!**/pnpm-lock.yaml`

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The update focuses on replacing the rate limiting and Redis dependencies from Upstash with rate-limiter-flexible to make the application more self-hostable. @upstash/ratelimit and @upstash/redis dependencies were removed from the project, and the core rate limiting logic was refactored to use RateLimiterRedis from rate-limiter-flexible.

Changes

File Change Summary
apps/web/package.json Removed @upstash/ratelimit and @upstash/redis. Added rate-limiter-flexible.
.../src/api/routes/v1_event.ts Replaced Upstash ratelimit logic with rateLimiter implementation using rate-limiter-flexible.
.../src/server/common/ratelimit.ts Introduced new rateLimiter setup and checkRateLimit function using RateLimiterRedis.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Remove @upstash/redis dependency (#143) โœ…
Remove @upstash/ratelimit dependency (#143) โœ…
Add a new rate limiting library (#143) โœ…

Poem

In the codebase, nimble lines have danced, From Upstash ties, they cleanly chanced, A flexible guard, now in place, With rate limits, setting the pace. Hopping free, like a rabbit in dawn's first light, CodeRabbit smiles at this vibrant new sight.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rajesh-jonnalagadda commented 5 months ago

@cstrnt please review

rajesh-jonnalagadda commented 5 months ago

This looks really good! I think it would be amazing if you could extract the checkRateLimit function with the ratelimiter to it's own file/module so that we can potentially re-use this :) Otherwise this looks amazing!

can I move these functions to /home/rajesh/github/abby/apps/web/src/api/routes/utils.ts

cstrnt commented 5 months ago

This looks really good! I think it would be amazing if you could extract the checkRateLimit function with the ratelimiter to it's own file/module so that we can potentially re-use this :) Otherwise this looks amazing!

can I move these functions to /home/rajesh/github/abby/apps/web/src/api/routes/utils.ts

Would prefer server/common/ratelimit.ts

rajesh-jonnalagadda commented 5 months ago

This looks really good! I think it would be amazing if you could extract the checkRateLimit function with the ratelimiter to it's own file/module so that we can potentially re-use this :) Otherwise this looks amazing!

can I move these functions to /home/rajesh/github/abby/apps/web/src/api/routes/utils.ts

Would prefer server/common/ratelimit.ts

done

cstrnt commented 5 months ago

@rajeshj11 the pnpm-lock.yaml is out of sync. Could you please run pnpm i locally and check in this file?

rajesh-jonnalagadda commented 5 months ago

Ok