tryabby / abby

Open-Source Feature Flags, Remote Config & A/B Tests for Developers ⛳🧪
https://www.tryabby.com
GNU Affero General Public License v3.0
143 stars 19 forks source link

Improve Remote Config Type UI when updating Remote Config Value #73

Closed cstrnt closed 1 year ago

cstrnt commented 1 year ago

The disabled state for the Update Remote Config Modal looks odd. There should be more visual clarity that the fields are disabled and a better indicator for the current value

Screenshot 2023-10-02 at 15 28 14

imSyntn commented 1 year ago

can you explain the issue a little bit clearly

CakeWithDivinity commented 1 year ago

@imSyntn A remote config value cannot change its type when you try to edit it. You can only change the type when you first create it. The modal is the same, that's why this type select is still visible, so that the user knows the type of the remote config, they are trying to edit.

In this case the Number option is selected and the field is disabled. But it doesn't really look disabled, because Number has a lower opacity than the disabled options.

The other options should have a lower opacity than the selected option, so that it is clear to the user, what option is selected and that they cannot change the type.

arjun-gr commented 1 year ago

Okay so if i am correct, You want the selected option to be more visible than the other 2 which are disabled ?

CakeWithDivinity commented 1 year ago

@arjun-gr Yeah, essentially the whole field is disabled, so it should not seem clickable, but it should be clear to the user what option is selected.

deverestHood commented 1 year ago

@cstrnt Hello! Could you assign this issue to me, and point me towards the files/code for the remote config type UI? Thanks so much!