add expiry to message - Githubissues

trycourier / courier-java

Java SDK for communicating with the Courier REST API.

MIT License

7 stars 5 forks source link

Description of the change

add the property "expires" that contains "expires_at" and "expires_in"

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#1]()

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

C-7815 update expiry

> **Detailed Description** **Why do we need this change?** Background: based on feedback, duration should be using: [https://tc39.es/proposal-temporal/docs/duration.html#:\~:text=Briefly%2C%20the%20ISO%208601%20notation,suffix%20that%20indicates%20the%20unit](https://tc39.es/proposal-temporal/docs/duration.html#:\~:text=Briefly%2C%20the%20ISO%208601%20notation,suffix%20that%20indicates%20the%20unit) Figma spec (if any): Steps to reproduce (if an issue/bug): > **Who are the stakeholders (customers, other teams/functions etc)** > **Any Follow-ups required (customer communication, slack ACK, etc)** > **Additional Context** Link to intercom/slack/discord > **Acceptance Criteria** * [ ] Documentation * [ ] Unit Tests * [ ] Smoke Tests * [ ] Rainforest * [ ] Works on all supported screen sizes * [ ] Load testing