Loosen CourierClientInterface to allow nullable params - Githubissues

trycourier / courier-php

A PHP package for communicating with the Courier REST API.

https://packagist.org/packages/trycourier/courier

MIT License

11 stars 4 forks source link

Loosen CourierClientInterface to allow nullable params #22

Closed defnorep closed 3 years ago

defnorep commented 3 years ago

The CourierClient class has nullable parameters, so the interface was too strict.

This commit also introduces a .gitignore and composer.lock which were not present prior.

Description of the change

Description here

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

[x] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request