trycourier / courier-php

A PHP package for communicating with the Courier REST API.
https://packagist.org/packages/trycourier/courier
MIT License
11 stars 4 forks source link

Proposal: Extract Laravel implementation to a separate repository #30

Open slashequip opened 2 years ago

slashequip commented 2 years ago

I would like to propose the the Laravel code is removed from this repository and moved to it's own separate repository.

trycourier/courier-php

trycourier/courier-laravel

Imagine;

$user->notify(new InvoicePaid($invoice));
// Triggers a sendNotification() call to courier with the user reference and additional profile data etc. 🤤
slashequip commented 2 years ago

Feel free to tell me to stop 😂

slashequip commented 2 years ago

I'll look to put together an example repository together under my GitHub account, see what you think and we can discuss moving forward 😄

tk26 commented 2 years ago

@slashequip apologies I haven't been able to go deep on this proposal just yet. Will def get back later today :)

slashequip commented 2 years ago

Don't worry about it, began to put a few things together here; https://github.com/slashequip/courier-laravel/ to replicate existing features and I'll begin to play around with the idea of this notification.

Even if this isn't something Courier wants to own/maintain the package should have merit on it's own anyway.

tk26 commented 2 years ago

sounds good, thanks @slashequip 🥇