search

trydionel / git-pivotal

A collection of git utilities to ease integration with Pivotal Tracker
MIT License
356 stars 46 forks source link

SSL Project Support #29

Closed bunnymatic closed 13 years ago

bunnymatic commented 13 years ago

Hey there

I know there was an issue in the github issue tracker for this. And i just ran into it on one of my projects. I've implemented a fix that uses a config (commandline or git config) option to use-ssl. I updated specs accordingly.

Cheers Jon Rogers @ 2rye.com

trydionel commented 13 years ago

Thanks bunnymatic! Would you mind to revert your changes to VERSION, the gemspec and spec_helper.rb? I'd be happy to merge this in after that.

anderssonjohan commented 13 years ago

Oh, it would be great to have support for SSL. Great work! We're on SSL only and when trying git-pivotal all I got was this:

Retrieving latest chores from Pivotal Tracker for Johan Andersson... /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/abstract_response.rb:48:in return!': 400 Bad Request (RestClient::BadRequest) from /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/request.rb:228:inprocess_result' from /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/request.rb:176:in transmit' from /opt/local/lib/ruby/1.8/net/http.rb:543:instart' from /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/request.rb:170:in transmit' from /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/request.rb:64:inexecute' from /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/request.rb:33:in execute' from /opt/local/lib/ruby/gems/1.8/gems/rest-client-1.6.3/lib/restclient/resource.rb:54:inget' from /opt/local/lib/ruby/gems/1.8/gems/pivotal-tracker-0.3.1/lib/pivotal-tracker/project.rb:14:in find' from /opt/local/lib/ruby/gems/1.8/gems/git-pivotal-0.8.0/bin/../lib/commands/base.rb:51:inproject' from /opt/local/lib/ruby/gems/1.8/gems/git-pivotal-0.8.0/bin/../lib/commands/pick.rb:71:in story' from /opt/local/lib/ruby/gems/1.8/gems/git-pivotal-0.8.0/bin/../lib/commands/pick.rb:28:inrun!' from /opt/local/lib/ruby/gems/1.8/gems/git-pivotal-0.8.0/bin/git-chore:7 from /opt/local/bin/git-chore:19:in `load' from /opt/local/bin/git-chore:19

Everything worked well when turning off SSL for the project.

Keep it up...

bunnymatic commented 13 years ago

@anderssonjohan, this fix will get around the exact bug you have showing.

@trydionel, sorry about the version mod. i meant to leave that out of the checkin. I'll get that fixed up and resubmitted.

cheers

bunnymatic commented 13 years ago

i removed the version mods and re-pushed. Do I need to submit another pull request? or can you pull the 2 commits together?

trydionel commented 13 years ago

Nope, that'll do the trick! (Isn't Github's new pull interface amazing?) I'll review and merge it this weekend.

Thanks bunnymatic!

anderssonjohan commented 13 years ago

@trydionel: Just wondering if you have an ETA for your merge? Big thanks in advance!

trydionel commented 13 years ago

Sorry folks, I was tied up with work this weekend. I'll do my best to get this out in the next couple days.

anderssonjohan commented 13 years ago

Awesome. Den 8 aug 2011 21.52 skrev "trydionel" < reply@reply.github.com>:

Sorry folks, I was tied up with work this weekend. I'll do my best to get this out in the next couple days.

Reply to this email directly or view it on GitHub: https://github.com/trydionel/git-pivotal/pull/29#issuecomment-1757477

trydionel commented 13 years ago

Merged and released! Grab v0.8.1 for SSL support. Thanks bunnymatic!

bunnymatic commented 13 years ago

glad i could help.

thanks for the merge. jon