trydis / FIFA-Ultimate-Team-Toolkit

FIFA Ultimate Team Toolkit
MIT License
233 stars 110 forks source link

What's not working? #1

Closed trydis closed 9 years ago

trydis commented 10 years ago

Please report it here, only made the changes needed to make the login work + the URL's.

BenAUK commented 10 years ago

Is there a way to search for a player by surname? i.e. Messi.

artielange commented 10 years ago

No, but there are plenty of csv files floating around with the data. Put that in a table and query your table for the assetid.

BenAUK commented 10 years ago

Can that be done similarly for Auction Searching? Cause i don't think you can search auctions by asset id?

artielange commented 10 years ago

Sure you can search the market with the assetId

Everyone hates it cause you get all the resourceIds for a given assetId, i dont mind cause i like to build my pricing DB

BenAUK commented 10 years ago

Do i just need to extend my PlayerSearchParameters to include an assetId?

artielange commented 10 years ago

I use the ResourceId parameter and set it to the assetId. I've never tried setting a resourceId directly (although I did in FUT14, and it didn't work, empty results everytime)

BenAUK commented 10 years ago

Thanks! helped alot

artielange commented 10 years ago

I don't know what the resourceId constant is this year (constant added to the assetId to get the different versions of the assetId) but if you do find that constant, you should be able to calculate the resourceId for EX. Diego Costa IF... then maybe you could set the parameter to the resourceId of the IF card... then your search would contain results containing only the IF version.

I know it wasn't possible last year, but it might be this year? If you feel like it, test it out and see what happens

BenAUK commented 10 years ago

Dont suppose you could point me in the direction of these CSV files of player data?

artielange commented 10 years ago

I'll see what I can find. If anything, I've got one at home I could send you. XBOX legends et al

artielange commented 10 years ago

Well it sounds like you're trying to reproduce the WebApps functionality...?

Wheres the automation?

Are you planning on selling this solution?

Spettacolo83 commented 10 years ago

I have the same error: exception "Code: PermissionDenied, String: Permission Denied" in this code: when i execute var auctionResponse = await client.PlaceBidAsync(auctionInfo);

Is possible fix this error?

artielange commented 10 years ago

It is possible. The answer is simple, you were outbid

By the time you placed your bid, there was already a bid placed that was higher than what you attempted to bid.

You must query the status of the auction once again in order to determine the new currentbid, and then place a new bid which is higher than the current.

dalso182 commented 10 years ago

Or just put it in a try/catch, if you query the status of the auction you spend some precious miliseconds :P, so find and item, bit on it

On Tue, Sep 30, 2014 at 9:47 AM, artielange notifications@github.com wrote:

It is possible. The answer is simple, you were outbid

By the time you placed your bid, there was already a bid placed that was higher than what you attempted to bid.

You must query the status of the auction once again in order to determine the new currentbid, and then place a new bid which is higher than the current.

— Reply to this email directly or view it on GitHub https://github.com/trydis/FIFA-Ultimate-Team-2015-Toolkit/issues/1#issuecomment-57335054 .

Diego Alvarez Solano Senior Web Developer PHP/MySQL/HTML/CSS/JavaScript/XML TEL: 8829 3412

artielange commented 10 years ago

..... Without querying the status, how would you know what the new current bid is...?

artielange commented 10 years ago

Its not easy to find out why the markets get broken so quickly, people bidding uselessly cause they don't know what the new current bid is

dalso182 commented 10 years ago

it works for me when buying now,

var searchResponse = await client.SearchAsync(currentItem.SearchParameter); AuctionInfo auctionInfo = searchResponse.AuctionInfo.First(); var itemPrice = auctionInfo.BuyNowPrice; var auctionResponse = await client.PlaceBidAsync(auctionInfo, itemPrice);

I don't even spend time looping over the all the results, since I know I'm looking for a lower price than usual I just try to buy it now.

All that code is in a try so, if there are no results it just keep moving and search again, until it finds something, I'm not sure how good the code is but my only purpose is to be as quicker as I can.

On Tue, Sep 30, 2014 at 10:24 AM, artielange notifications@github.com wrote:

Its not easy to find out why the markets get broken so quickly, people bidding uselessly cause they don't know what the new current bid is

— Reply to this email directly or view it on GitHub https://github.com/trydis/FIFA-Ultimate-Team-2015-Toolkit/issues/1#issuecomment-57340843 .

Diego Alvarez Solano Senior Web Developer PHP/MySQL/HTML/CSS/JavaScript/XML TEL: 8829 3412

artielange commented 10 years ago

Yes, that makes sense when buying, not bidding though

artielange commented 10 years ago

The bottom line is permission denied means you were too slow, either to bid the amount you're tying to bid, or to buy the item cause it was already bought

pradella commented 10 years ago

@benAUK, you can get the player name by resourceid here: https://fifa15.content.easports.com/fifa/fltOnlineAssets/8D941B48-51BB-4B87-960A-06A61A62EBC0/2015/fut/items/web/players.json

MCyike commented 10 years ago

I'm also getting the Permission Denied error all the time using the same as above. It's happening on nearly every bid attempt.

var auctionResponse = await client.PlaceBidAsync(auctionInfo);

The problem is if I research the same player straight afterwards, the current bid amount has not changed... so I can't be getting outbid.

untitled

Any ideas? I haven't tried entering the amount explicitly, but since the toolkit calculates the next valid amount from the current bid I can't see it making any difference.

BenAUK commented 10 years ago

Just wondering guys, your problem with the permission denied thing isn't anytbibg to do with the fact FIFA have disabled trading it is?

MCyike commented 10 years ago

Nope I'm on PS. I've tried bidding through the actual web app and it seems fine. Even using Fiddler I can't see anything different (the request is /fifa15/trade/itemid/bid, the same as the toolkit), but for some reason it doesn't work.

I'm far from an expert with Fiddler though.

artielange commented 10 years ago

Its cause you were outbit, im 100% sure of this. Why would some bid requests work fine while others don't? Nothing wrong with the request...

MCyike commented 10 years ago

I know that's what used to happen in 14... but it's not the case this time. Something has changed. It's virtually every player.

artielange commented 10 years ago

... I dunno what to say. I'm getting a lot too. But I'm sure its cause I'm too slow

stefanoIT commented 10 years ago

Outbid afaik, And I add that there are already a fuckload of bots on the market.

artielange commented 10 years ago

Che bello raggazzo

MCyike commented 10 years ago

Look at my reply again... this isn't a BIN issue.

artielange commented 10 years ago

Doesn't need to be a BIN issue:

You use CalculateBid to get the next valid bid on the auction You bid the value returned by CalculateBid The value returned by CalculateBid is no longer valid because someone else already bid that amount or higher You receive permission denied because you are trying to perform an illegal action (i.e. bidding a lower value than the current bid)

If it isn't that, please provide the steps you took to establish that this isn't what is actually happening on your end. Anything is possible, just show me the money

MCyike commented 10 years ago

Dude, look at the picture I attached...

artielange commented 10 years ago

So between the 42 second and 59 second, you got the auction status again and the current bid was still 3200? Is that what you're trying to show with the image?

Could it be the item was BINNED?

MCyike commented 10 years ago

If it was BIN'd it wouldn't show up again. Since the current bid is the exact same 15 seconds later... how would I have been outbid?

It's happening on every auction. You clearly don't want to believe it so I'll wait and see what others have to say.

artielange commented 10 years ago

I didn't say I didn't believe you. I'm trying to tell you what you're reporting doesn't jive with what others are reporting.

Did you requery the status of the auction? in that 15 second time span using .GetTradeStatusAsync ?

MCyike commented 10 years ago

I don't use trade status. I completely re-searched by resource ID, and the same card is still there with the same current bid. There are clearly others above having the same issue (with regular bidding only).

I used this toolkit all through FIFA 14 doing the same thing and never had this issue with regular bidding (it would obviously happen quite frequently with BINs).

ulrickpsp commented 10 years ago

Hi mates, first of all thank you all, specially trydis. I'm quite new in this programming language and with this development tool but I'm trying to learn.

My question is, how could I get the response of the login to see if it's been successfully or not?

I'm a bit stuck here:

var loginResponse = await client.LoginAsync(loginDetails);

stefanoIT commented 10 years ago

@MCyike I'm sorry pal, I haven't noticed the attached pic earlier. The only thing that comes to my mind is something related to inconsistent data. I mean that card has been bid by someone else, hence the exception, but its status hasn't been updated properly on the search response. I don't really know how EA manage the indexing / searches criteria but we've already seen in the past how shit bad they are on this kind of tasks. I won't exclude a such kind of issue.

stefanoIT commented 10 years ago

@ulrickpsp you'll get an exception if your login fails. Use a try catch to manage your status properly

artielange commented 10 years ago

I see that kind of stuff happening on the console sometimes... the card doesn't have a bid on it unless you try to bid, then the bid gets "refreshed". could be slow status changes I guess yeah.

MCyike commented 10 years ago

Might want to delete your account details bud.

As for my issue, I have to assume it's something like that. It's just odd that this never really happened in UT14...

stefanoIT commented 10 years ago

@ulrickpsp Mate I strongly advice to edit your post, deleting your account informations. Change your password and your security question, those boards are public :)

Back on topic, something like

Try { // your code here var loginResponse = await client.LoginAsync(loginDetails);

// If I'm here it means Im logged in properly

} Catch (FutException ex) { // something went wrong } Catch (Exception ex2) { // something went wrong }

artielange commented 10 years ago

@MCyike Indeed very strange. I'm going to do some investigating tonight to see if I can confirm your suspicions...Some bids succeed so I never really gave it a second thought...

artielange commented 10 years ago

You did it again! Remove your login details!!!

stefanoIT commented 10 years ago

@ulrickpsp uhm last time I had this exception was on FUT14 and the servers were just fucked up / busy / full

pradella commented 10 years ago

@stefanoIT in addition to your explanation (about try catch), is it possible to use FutErrorException as well?

ulrickpsp commented 10 years ago

Stupid question, do you use your real account with this software?

artielange commented 10 years ago

@MCyike alright i had a look at my logs and it seems like you might be on to something... for at least one bid request, i started off by getting an internal server error. i was surprised because it was an incredibly low bid on a normally high priced item. once i got that error, i tried to bid again and kept getting permission denied. auction state was "active" but time remaining was 0 (not -1). this may be similar to the behavior we saw last time with "stuck" tradepile items? in any event... it was definitely weird ill keep looking

stefanoIT commented 10 years ago

@pradella Yes mate, FutErrorException inherits from FutException

ulrickpsp commented 10 years ago

Hi mates, finally got it to work. I've one question. Is there any way to look for PLAYER CONTRACTS only instead of both players and coaches contracts?

Thanks in advance

BenAUK commented 10 years ago

Hey guys, dont suppose some very kind person would let me have access to a test Playstation account? i was using my xbox account but they have disabled xbox for now :(