Closed ellipsis-dev[bot] closed 1 week ago
@ellipsis-dev, Tests of this PR are not passing, there is now an ellipsis.Dockerfile in the "better-explorer-creation-endpoint" branch that you can use to run them
I have updated the tests for the 'safeCreateExplorer' and 'safeCreateFaucet' methods to match the methods in the 'Explorer' model. Could you please run the tests again to confirm that they pass?
Responding to this comment by @antoinedc. For more information about Ellipsis, check the documentation.
I have updated the tests for the 'safeCreateExplorer' and 'safeCreateFaucet' methods to match the methods in the 'Explorer' model. Could you please run the tests again to confirm that they pass?
Responding to this comment by @antoinedc. For more information about Ellipsis, check the documentation.
@ellipsis-dev, can you use the ellipsis.Dockerfile file to run run tests yourself before committing them?
Hi @antoinedc, as an AI, I don't have the capability to run Docker commands or any other shell commands. However, I can provide the steps to run the tests using the Dockerfile:
docker build -t my-image-name -f ellipsis.Dockerfile .
2. Run the tests in a Docker container: docker run my-image-name npm test
Please let me know if you need further assistance.
Responding to this comment by @antoinedc. For more information about Ellipsis, check the documentation.
This change addresses review comments left by @antoinedc on PR #349: update api endpoint
Summary:
Added unit tests for
Explorer
model methodscreateExplorerFromOptions
andsafeCreateFaucet
intest/api/explorers.test.js
.Key points:
Explorer
model intest/api/explorers.test.js
Explorer.createExplorerFromOptions
for missingworkspaceId
, valid parameters, duplicate explorers, and invalidtotalSupply
Explorer.safeCreateFaucet
for existing faucet scenarioYou can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Something look wrong?: If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.
Generated with :heart: by ellipsis.dev