More tests for edge cases

tryfer / node-tryfer

A Node Zipkin Tracer Library.

Apache License 2.0

45 stars 27 forks source link

More tests for edge cases #4

Closed Kami closed 11 years ago

Kami commented 11 years ago

Previously an unhandled exception was thrown is a RESTkin endpoint couldn't be reached.

I've modified it to log an error instead of exploding.

Ideally, RESTkinTracer class would inherit from EventEmitter and emit an error instead of logging, but because it currently already inherits from EndAnnotationTracer, that's not possible.

cyli commented 11 years ago

Other than the test case name, LGTM.