search

tryfer / node-tryfer

A Node Zipkin Tracer Library.
Apache License 2.0
45 stars 27 forks source link

Add support for X-B3-Sampled header and sampled flag in Trace object #41

Closed drpacman closed 8 years ago

drpacman commented 8 years ago

The current absence of support for sampled headers means that a sampling decision at the edge of a suite of services is not honoured on downstream systems.

This pull request addresses that issue and ensures that the holistic sampling decision for the current node (be it inherited from upstream request headers, or made locally) is also made available in the trace headers, so they can be attached to any downstream request

drpacman commented 8 years ago

Hi @dustyburwell, Are there any remaining aspects that you feel need addressing? If not do you know when you may be able to merge this pull?

dustyburwell commented 8 years ago

@drpacman this looks good otherwise. If you wouldn't mind doing a quick rebase, I'll get this merged.

drpacman commented 8 years ago

@dustyburwell, hope thats all good now