Batch send support and consistency with python client

tryfer / node-tryfer

A Node Zipkin Tracer Library.

Apache License 2.0

44 stars 27 forks source link

Batch send support and consistency with python client #7

Closed Kami closed 11 years ago

Kami commented 11 years ago

This branches does the following:

Makes Node.js client API consistent with the Python client API
Adds support for batch sending of the traces
Changes some style stuff so it's consistent with Node.js style convetions

Kami commented 11 years ago

@dreid, @cyli ^^

cyli commented 11 years ago

Could use a little more test coverage in the following areas wrt to the buffered non restkin tracers, but I'm ok with doing that in a separate pull request if this is blocking, especially since we don't seem to be using the other tracers. +1

Kami commented 11 years ago

@cyli I definitely agree about the tests for some of the things which are currently not being used.

I will do my best to work on this in a separate PR as soon as possible.