search

tryfer / node-tryfer

A Node Zipkin Tracer Library.
Apache License 2.0
44 stars 27 forks source link

ZipkinTracer bug fix allows scribeClient to push messages onto it's queue #9

Closed eodgooch closed 11 years ago

eodgooch commented 11 years ago

Line 220 of node_tracers.js should be

this.scribeClient.send.bind(this.scribeClient, this.category)

I also updated the version # for my local application and created a example zipkin server/client.

Kami commented 11 years ago

First thanks for you pull request and the example server and client!

Now an advice for the next time - it would be a lot easier for us if you split this pull request into multiple ones:

  1. Pull request which fixes a bug
  2. Pull request which adds an example
Kami commented 11 years ago

Thanks for addressing those comments - I've merged your changes into master.

Kami commented 11 years ago

Published v0.2.6 to npm.