search

trympet / homebridge-volvo

Volvo plugin for Homebridge
https://npm.im/homebridge-volvo
Apache License 2.0
26 stars 6 forks source link

Fix enabledFeatures configuration bug #25

Closed drakkhen closed 3 years ago

drakkhen commented 3 years ago

There were a few problems causing the enabledFeatures configuation object from being ignored (thus all features were enabled, even when the user preferred to hide some):

  1. the object was not being included in the object returned from src/helpers.ts, and

  2. the check to see which features were disabled was trying to find the feature name in the config object directly, instead of looking in config.enabledFeatures.

This change allows users to hide features they would prefer not to see (or that are currently malfunctioning, i.e., preclimatization), and thus resolves Issue #12.

trympet commented 3 years ago

Closes #12

trympet commented 3 years ago

@drakkhen, good! Thank you for digging though the code.