trympet / homebridge-volvo

Volvo plugin for Homebridge
https://npm.im/homebridge-volvo
Apache License 2.0
26 stars 6 forks source link

Temp fix for #6 #7

Open trympet opened 4 years ago

trympet commented 4 years ago

Prevents errors being thrown when getting heater status while the "heater" object is missing. This is not a permanent fix, as the accessory will always be shown as OFF. However, this allows the user to turn the heater on or off, albeit with incorrect status reporting.

trympet commented 4 years ago

Also, it appears that only NA is affected by this.

drakkhen commented 3 years ago

It’s weird that the heater object is simply not in the response. Not sure how the official Volvo app is getting that info.. 🤔

GH-25 fixes the issue with features not being hidden. Maybe we can revise the temp fix by using that change and then disabling preclimatization by default?

trympet commented 3 years ago

GH-25 fixes the issue with features not being hidden. Maybe we can revise the temp fix by using that change and then disabling preclimatization by default?

Good idea. Up for grabs! 😄

drakkhen commented 3 years ago

Created PR-27 which -- I think -- should disable the preclimatization feature by default on fresh installs.