Closed codewithmichael closed 9 years ago
Seems to me we'll need to release this across two releases — one to add the new var and one to remove the old one.
We might want to go ahead and try to get the first part into the release-next
(v0.1.2) since it's already going to be a conversion release containing the new wren
control script (#11+#16).
This is probably going to completely conflict with PR #17, but I'll put it under it's own branch all the same.
This issue is addressed by PR #19 (_Implement new RUN_ENV_PLATFORMPATH variable), which is ready to go.
To address the "release this across two releases" point, I'll add a ### DEPRECATED ###
comment to the RUN_ENV_PLATFORM_NAME
entries in both /etc/environment
and /etc/sudoers
(via wrender
).
Released in v0.1.2.
The only reason we store
RUN_ENV_PLATFORM_NAME
in/etc/environment
is so that we can find the installed platform files. It would make more sense to simply define a path — i.e.RUN_ENV_PLATFORM_PATH
— so that the platform name doesn't have to change simply to accommodate alternate install locations.Besides, as was adequately pointed out in #15 (Remove platform version and display name from environment variables), it's strange for the name, or any environment variable for that matter, to be defined in more than one place.
This change would also allow us to remove the checks for external variable declaration from
RUN_ENV_PLATFORM_NAME
andRUN_ENV_PLATFORM_DISPLAY_NAME
. However, we may want to keep the external display name allowance for offshoot/wrapper projects.