quick revert for no data bug - Githubissues

trynmaps / metrics-mvp

Prototype of public transit data visualization system

https://muni.opentransit.city

MIT License

30 stars 34 forks source link

quick revert for no data bug #622

Closed bmblumenfeld closed 4 years ago

bmblumenfeld commented 4 years ago

Proposed changes

Very quick fix for no data error in InfoTripSummary. This is not an ideal fix just a patch so not getting blank screen on prod. Seems there was a change in commit: https://github.com/trynmaps/metrics-mvp/commit/cabe88a5ba1dc7f605b6cb267b1f6fff10cec69a That defaulted scores to null instead of empty object. Just changed it back.

A better fix would be handling for no data case and reflect that in the view; however, I don't know how common this is so might not be worth it.

Steps to test

Select route and set a trip with start and end stops. Trip summary cards should render greyed out.

hathix commented 4 years ago

Looks fine, though I still get a blank screen error on the homepage and can't test properly.