Improvements to journey info table

trynmaps / metrics-mvp

Prototype of public transit data visualization system

https://muni.opentransit.city

MIT License

30 stars 34 forks source link

Improvements to journey info table #639

Open hathix opened 4 years ago

hathix commented 4 years ago

I was viewing this route comparison:

Thoughts:

Isn't it a bad thing for on-time rate to go down 20%? In that case, shouldn't the text be orange/red instead of green?
The completed trips metric isn't all that useful, since the date ranges are different lengths. "Completed trips per day" for multiple-day routes would be ideal.
For Median Wait Time, I'd rather see it called "even" rather than not having a label at all.

hathix commented 4 years ago

I'm starting to work on this in the route-table branch. Others can run with this if I don't finish it quickly.

hathix commented 4 years ago

Update -- no need for "even" since nothing is truly equal. In my branch I'm just going to make it show "<1" if the difference is very small; currently that code path doesn't trigger.

But I did fix the on-time rate coloring issue. The completed trips metric might be big enough to deserve its own PR.

hathix commented 4 years ago

https://github.com/trynmaps/metrics-mvp/tree/route-table

hathix commented 4 years ago

The completed trips bit is hard. You'd have to do it per hour for it to really be valuable.