Closed aspeake closed 3 months ago
@trynthink thanks for the review. I think I've addressed each of your comments and do not have any followups. I added a CI job to check that the readable config in the docs has been updated for any changes with the schema: https://github.com/trynthink/scout/pull/355/commits/4d89032b0fcc6820d91a1ce7a4d66d2c5bbd3648. Given I didn't even update it in this PR, it seems like an easy thing to miss. I stopped short of an automatic commit to update, and instead just fail the CI.
Update how arguments for ecm_prep.py and run.py are handled. A configuration .yml file is introduced to simplify running these scripts, improve repeatability, and allow for version control. New arguments are introduced as needed to replace the user prompts and responses. Additionally, a new set of tests is added to cover these new features and as well as gaps in testing for existing argument handling.
Summary of Changes
Functionality Changes
python scout/ecm_prep.py -y <myyml>.yml
) or by passing CLI arguments directlyExample yml Input: