Compatibility fixes (up-to-date Django/tastypie) + POST/PATCH/PUT support

tryolabs / django-tastypie-extendedmodelresource

An extension for TastyPie's ModelResource, to allow features such as easily having multiple nested resources.

https://tryolabs.com

44 stars 14 forks source link

Compatibility fixes (up-to-date Django/tastypie) + POST/PATCH/PUT support #4

Open Jorl17 opened 8 years ago

Jorl17 commented 8 years ago

Hi, I've used this awesome project in one of my projects, but had to adapt it to support the most recent django, as well as the most up-to-date tasty pie (these changes are all backwards compatible

I have also enabled PATCH/POST/PUT support, which works, although it uses the nested resource's authenticator (which I prefer, to be honest).

Hoping you accept the pull request. Perhaps you would prefer to re-disable PATCH/POST/PUT. If that is the case, I can submit another pull request only with the compatibility fixes.

Jorl17 commented 8 years ago

Thank you for your input and apologies if the code is somewhat subpar. These issues should be fixed with some documentation at 12aa0b0ecf5bc472bad9537346838f28f3eac37f.

dekked commented 8 years ago

I'd even say we drop compatibility with old TastyPie versions; just makes the code more convoluted.

What do you think?

Jorl17 commented 8 years ago

Sounds like a plan. In the coming days I'll commit a much cleaner version without all the backwards-compatible cruft :)

Jorl17 commented 8 years ago

Done at https://github.com/Jorl17/django-tastypie-extendedmodelresource/commit/533f2d4c37ef5f0b0920b57cdedefd3ce983eef1

Jorl17 commented 8 years ago

Friendly reminder bump :)

dekked commented 8 years ago

Sorry for the delay @Jorl17, I was traveling!

Does the sample project work with the latest updates? If not, it would need update.

Other things that I notice before we release, all regarding the README.md.

You added yourself to contributors, but also need date + version bump.
The mention that the sample project requires Django 1.4.1. It would be wise to have the sample using the latest Django version.
Are the explanatory code samples in the readme still accurate?

Sorry for all the comings and goings on this, and again for the delay in my reply.