search

tryolabs / norfair

Lightweight Python library for adding real-time multi-object tracking to any detector.
https://tryolabs.github.io/norfair/
BSD 3-Clause "New" or "Revised" License
2.34k stars 237 forks source link

Set draw_labels to false by default #303

Open aguscas opened 4 months ago

aguscas commented 4 months ago

The default value for draw_labels was not the same in draw_boxes and draw_points. For consistency, I think it would be better to have the same default value

javiber commented 4 months ago

Does this affect any demo? maybe the videos look different now if they were relying on the default argument

aguscas commented 4 months ago

Does this affect any demo? maybe the videos look different now if they were relying on the default argument

I would argue that doing this make the demos even more consistent with the videos we show in their README. As you can see in the yolov7 demo when we use this function we use the default value, but in the video in the README there is no label. That is because the video was generated with the old drawing functions, and when we updated the drawing functions we forgot to pass the argument to not draw the labels.