feat(auth): Added form validations using Zod schema

trypear / pear-landing-page

Landing page for PearAI, the Open Source AI-Powered Code Editor

https://trypear.ai

47 stars 73 forks source link

feat(auth): Added form validations using Zod schema #102

Closed Ibinola closed 3 months ago

Ibinola commented 3 months ago

Description

Added form validations using Zod schema for all inputs of user workflows.

Related Issue

Fixes - #96

Changes Made

added a loading state when submitting forms
error handling to display validation messages on invalid inputs.

Screenshots

Reset Password

Checklist

[x] I have tagged the issue in this PR.
[x] I have attached necessary screenshots.
[x] I have provided a short description of the PR.
[x] I ran yarn build and build is successful

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pear-landing-page	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 6:21pm
pear-landing-page-uwmp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 6:21pm

vercel[bot] commented 3 months ago

@Ibinola is attempting to deploy a commit to the PearAI Team on Vercel.

A member of the Team first needs to authorize it.

Fryingpannn commented 3 months ago

WILL REVIEW THIS SOON. Haven't checked yet but wanted to flag that there is some built in validations rn

e.g.

ICEPrey commented 3 months ago

Can you please follow the shadcn form https://ui.shadcn.com/docs/components/form

yea I do agree that we should stick to shadcn components and use Form

Ibinola commented 3 months ago

Build failed Please check yarn build on local.

Other than that code LGTM , nice job @Ibinola Thanks for refactoring

fixed, also noticed when I had the optional method on the company name field on the sign-up form, it returned undefined

shrix1 commented 3 months ago

Build failed Please check yarn build on local.

Other than that code LGTM , nice job @Ibinola Thanks for refactoring

fixed, also noticed when I had the optional method on the company name field on the sign-up form, it returned undefined

CompanyName should be optional
maybe do like data?.company_name || null

Ibinola commented 3 months ago

Build failed Please check yarn build on local.

Other than that code LGTM , nice job @Ibinola Thanks for refactoring

fixed, also noticed when I had the optional method on the company name field on the sign-up form, it returned undefined

CompanyName should be optional

maybe do like data?.company_name || null

ohh okay i guess, yes did something like that, still didn't work, but this worked data.company_name || ""