tryphotino / photino.NET

https://tryphotino.io
Apache License 2.0
885 stars 73 forks source link

Move PhotinoServer.NET to the separate package #104

Closed misupov closed 2 years ago

misupov commented 2 years ago

Currently Photino.NET project is based on Microsoft.NET.Sdk.Web. It means, even if Photino-based application doesn't use PhotinoServer.CreateStaticFileServer(...), it still depends on lots of asp.net libraries. When I build HelloWorld app in a self-contained mode, the resulting folder size is about 97 megabytes. In my project I use custom scheme handler to host application resources, so I don't need to use PhotinoServer. However, when I run dotnet publish -r osx-arm64 --self-contained, I'm getting dozens of "Microsoft.AspNetCore.*.dll" files.

Does it make sense to split PhotinoServer and Photino core into separate nuget packages?

Thank you.

philippjbauer commented 2 years ago

@misupov Thank you, this is a good suggestion and we will work to implement it that way.