More flexible logging

[loop8ack]

Implemented a custom logger interface in Photino.NET to provide flexible logging solutions. This extension should be backward compatible.

I plan to develop an integration of Microsoft.Extensions.Logging within the photino.Blazor project:

internal sealed class MicrosoftPhotinoLogger : IPhotinoLogger
{
    private readonly ILogger _logger;

    public MicrosoftPhotinoLogger(ILoggerFactory loggerFactory)
    {
        _logger = loggerFactory.CreateLogger("Photino.NET");
    }

    public void Log(int verbosity, Exception exception, string message)
    {
        LogLevel logLevel;

        if (verbosity <= LogVerbosity.Critical)
            logLevel = LogLevel.Error;
        else if (verbosity <= LogVerbosity.Warning)
            logLevel = LogLevel.Warning;
        else if (verbosity <= LogVerbosity.Verbose)
            logLevel = LogLevel.Information;
        else if (verbosity <= LogVerbosity.Debug)
            logLevel = LogLevel.Debug;
        else
            logLevel = LogLevel.Trace;

        if (_logger.IsEnabled(logLevel))
            _logger.Log(logLevel, exception, message);
    }
}

Suggestion for Future Consideration

As an alternative improvement, integrating Microsoft.Extensions.Logging.Abstractions could be considered for future enhancements. This integration would necessitate breaking changes, such as the removal of the LogVerbosity property and SetLogVerbosity() method. It's also important to note that this integration would introduce an additional dependency on Microsoft.Extensions.DependencyInjection.Abstractions. Despite this, it offers a more unified and standardized approach to logging.

If an integration of "Microsoft.Extensions.Logging" is under consideration, then please feel free to view this pull request as an invitation for discussion.

[MikeYeager]

@loop8ack Thank you for the suggestion. Agreed that the internal logging on the .NET side was thrown in hastily. We would like to implement Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection.Abstractions, but it's not at the top of our priority list. Since all logging calls within Photino.NET are private, and likely should remain private, we shouldn't have to worry about breaking changes. We'll just have to make sure that if no logger is specified, we default to a console logger. Thoughts?

[loop8ack]

@MikeYeager The concern about BreakingChanges relates to the "LogVerbosity" property, as this is public and follows a concept that differs from the standard. The same applies to the "SetLogVerbosity" method.

If I use Microsoft.Extensions.Logging, the old LogVerbosity concept would be dropped, which leads to problems if someone has customized the LogVerbosity.

I guess that wouldn't be very bad, but I still wanted to get feedback first.

[loop8ack]

Is there any news on this?

If necessary, I can also create a new pull request with Microsoft.Extensions.Logging. That would probably be better, but would also be a breaking change.

[ottodobretsberger]

We are currently working on updating and bugfixing our Samples projects. When we get to incorporating new features, we will circle back to this and incorporate it on the next major release.